From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Save calculated transitionSpace in Agg node.
Date: Thu, 27 Feb 2020 18:36:36 -0500
Message-ID: <25326.1582846596@sss.pgh.pa.us> (raw)
In-Reply-To: <0d6f3e77dc0c02ee4ab44dff3c8b15ac8f06f99a.camel@j-davis.com>
References: <E1j7Opv-0002yK-8q@gemulon.postgresql.org>
<12491.1582833409@sss.pgh.pa.us>
<0d6f3e77dc0c02ee4ab44dff3c8b15ac8f06f99a.camel@j-davis.com>
Jeff Davis <pgsql@j-davis.com> writes:
> On Thu, 2020-02-27 at 14:56 -0500, Tom Lane wrote:
>> Surely this patch is a few bricks shy of a load. Don't you need
>> copyfuncs/readfuncs/outfuncs support, for starters?
> Sorry, I will fix it.
> I was looking at whether changes to copyfuncs (etc.) should also cause
> a catversion bump, and it seems inconsistent. Commit 9ce77d75 does, but
> 6ef77cf4 does not. Any particular rules around that? Not terribly
> important as the catversion was just bumped anyway; just curious.
You need a catversion bump if stored rules/views would change, ie when
messing with something that can appear in parser output. The old rule
of thumb was "if you touched readfuncs.c you probably need a catversion
bump", but this is less true now that we have read/write support for
plan trees (which need serialization support so we can send them to
parallel workers, but there's no permanent storage).
In this case, since it's only touching plan nodes, you need
copyfuncs/readfuncs/outfuncs adjustments but not a catversion bump.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Save calculated transitionSpace in Agg node.
In-Reply-To: <25326.1582846596@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox