From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add parallel-aware hash joins.
Date: Thu, 04 Jan 2018 15:16:15 -0500
Message-ID: <25496.1515096975@sss.pgh.pa.us> (raw)
In-Reply-To: <20180104200647.wna6yoin7nav5qqo@alap3.anarazel.de>
References: <CAEepm=2WFQrwDD4rEVKjdPBQ_di_0n=xYST1MDRsucZ=JgDPxg@mail.gmail.com>
<18190.1514943510@sss.pgh.pa.us>
<CAEepm=34PDuR69kfYVhmZPgMdy8pSA-MYbpesEN1SR+2oj3Y+w@mail.gmail.com>
<5187.1515028624@sss.pgh.p!a.us>
<CAEepm=1uuT8iJxMEsR=jL+3zEi87DB2v0+0H9o_rUXXCZPZT3A@mail.gmail.com>
<16320.1515046173@sss.pgh.pa.us>
<4847.1515081624@sss.pgh.pa.us>
<CA+TgmoY7JAxRW_UQZAyxH3=JXV3WTFdwfTdyGB3TySj7c1i2yg@mail.gmail.com>
<7839.1515085897@sss.pgh.pa.us>
<20180104192033.irv4ppf44i2fesze@alap3.anarazel.de>
<20180104200647.wna6yoin7nav5qqo@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2018-01-04 11:20:33 -0800, Andres Freund wrote:
>> Some packages on skink have been upgraded. It appears that there either
>> was a libc or valgrind change that made valgrind not recognize that a
>> pointer of 0 might not point anywhere :(
> ==5718== Invalid write of size 8
> ==5718== at 0x40E3DD: ExecInterpExpr (execExprInterp.c:1117)
> ==5718== by 0x40F5E9: ExecInterpExprStillValid (execExprInterp.c:1788)
> ==5718== by 0xE6B0409: ExecEvalExpr (executor.h:282)
Are those line numbers supposed to match current HEAD? 1117 does not
contain any write AFAICS:
if (!op->d.iocoerce.finfo_in->fn_strict || str != NULL)
> ==5718== Process terminating with default action of signal 11 (SIGSEGV)
> ==5718== Access not within mapped region at address 0x20
> ==5718== at 0x40E3DD: ExecInterpExpr (execExprInterp.c:1117)
> ==5718== by 0x40F5E9: ExecInterpExprStillValid (execExprInterp.c:1788)
This would be consistent with op->d.iocoerce.finfo_in being NULL, I think,
but there is no way that execExpr.c could have created an EEOP_IOCOERCE
step without filling in the finfo_in pointer.
I think the correct conclusion is that this version of valgrind is
buggy as hell. I wouldn't clutter our code with suppressions trying
to make it sort-of work.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, thomas.munro@enterprisedb.com, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Add parallel-aware hash joins.
In-Reply-To: <25496.1515096975@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox