pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver
Date: Fri, 17 Mar 2017 15:04:12 -0400
Message-ID: <25652.1489777452@sss.pgh.pa.us> (raw)
In-Reply-To: <927edd39-ed04-ea57-a98c-638eb0365431@2ndQuadrant.com>
References: <E1cjo1g-0000mr-ST@gemulon.postgresql.org>
	<19403.1488586564@sss.pgh.pa.us>
	<34d98fbf-9195-04d2-b85a-634d6952ffdf@2ndquadrant.com>
	<19815.1488600693@sss.pgh.pa.us>
	<4144256b-dc4f-892c-a720-71f6e7b9ac87@2ndquadrant.com>
	<dcef4616-21af-5ec0-4113-d409e5ddbf86@2ndquadrant.com>
	<3ffe98f7-d2ed-65c6-51f3-4d97ffd6e312@2ndquadrant.com>
	<e31d81e2-392a-dca0-a700-e28b583bd2d3@2ndQuadrant.com>
	<34591606-976a-bbee-8eda-778c1e1fc52f@2ndQuadrant.com>
	<10458.1489763266@sss.pgh.pa.us>
	<5b6a6d6d-fb45-0afb-2e95-5600063c3dbd@2ndquadrant.com>
	<13398.1489768097@sss.pgh.pa.us>
	<927edd39-ed04-ea57-a98c-638eb0365431@2ndQuadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 03/17/2017 12:28 PM, Tom Lane wrote:
>> I'll add some comments and push this.  Does everyone agree that
>> this had better get back-patched, too?

> Confirmed that this fixes the problem on jacana.
> +1 for backpatching.

I've pushed this into 9.6, but the WaitEventSet code doesn't exist before
that.  It might be that we should apply a similar fix to the predecessor
code, but I'm not really excited about it given that we have no indication
that the bug can be hit in the older branches.  Anyway, lacking a Windows
machine to test on, I have no interest in trying to make such a patch
blindly.

> Does that mean we could remove the special logic in pgstat.c?

If you mean the bit near line 3930 about

         * Windows, at least in its Windows Server 2003 R2 incarnation,
         * sometimes loses FD_READ events.  Waking up and retrying the recv()
         * fixes that, so don't sleep indefinitely.  This is a crock of the
         * first water, but until somebody wants to debug exactly what's
         * happening there, this is the best we can do.

that doesn't seem related --- that's about missing FD_READ events not
FD_WRITE.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (22+ messages)  latest in thread

Message-ID: <25652.1489777452@sss.pgh.pa.us>
Permalink:  ../25652.1489777452@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/25652.1489777452@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, petr.jelinek@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, pgsql-hackers@postgresql.org
  Subject: Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver
  In-Reply-To: <25652.1489777452@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox