From: Andrew Dunstan <andrew@dunslane.net>
To: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Transfer statistics during pg_upgrade.
Date: Fri, 21 Feb 2025 09:51:12 -0500
Message-ID: <25d26774-25fa-46f2-9888-c6a707d1fef7@dunslane.net> (raw)
In-Reply-To: <E1tl2sF-000HZG-2w@gemulon.postgresql.org>
References: <E1tl2sF-000HZG-2w@gemulon.postgresql.org>
On 2025-02-20 Th 4:29 AM, Jeff Davis wrote:
> Transfer statistics during pg_upgrade.
Small nit.
I notice this commit has introduced a couple of dubious uses of
"mututally exclusive":
doc/src/sgml/ref/pg_dump.sgml: This option is mutually exclusive
to <option>--data-only</option>
doc/src/sgml/ref/pg_dump.sgml- and
<option>--statistics-only</option>.
--
doc/src/sgml/ref/pg_restore.sgml: This option is mutually
exclusive of <option>--data-only</option>
doc/src/sgml/ref/pg_restore.sgml- and
<option>--statistics-only</option>.
I don't think this is idiomatic usage, and it's possibly not correct
usage. At best it is jarring. One does not normally follow "mutually
exclusive" with a preposition. I would replace the these with something
like "This option cannot be used with ...". If you want to use the
phrase, it should be something like "This option and ... are mutually
exclusive."
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Transfer statistics during pg_upgrade.
In-Reply-To: <25d26774-25fa-46f2-9888-c6a707d1fef7@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox