pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Richard Guo <rguo@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Ignore PlaceHolderVars when looking up statistics
Date: Fri, 02 Jan 2026 16:20:41 -0500
Message-ID: <271338.1767388841@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmobgfvw4w9javDG_aR3EqQC9AYssWcuns7-m4qLx1AyG=w@mail.gmail.com>
References: <E1va3GH-003FBe-35@gemulon.postgresql.org>
	<CA+Tgmobgfvw4w9javDG_aR3EqQC9AYssWcuns7-m4qLx1AyG=w@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Sun, Dec 28, 2025 at 9:45 PM Richard Guo <rguo@postgresql.org> wrote:
>> Back-patch to v18.  Although this issue exists before that, changes in
>> this version made it common enough to notice.  Given the lack of field
>> reports for older versions, I am not back-patching further.

> Generally we don't back-patch fixes that could change plans, because
> it tends to produce user complaints. It's maybe more justifiable in
> this case because v18 is quite new and you didn't back-patch to older
> releases, but are we sure that it's warranted even there?

It's a regression if we don't.  See nearby complaint at

https://www.postgresql.org/message-id/flat/b75866aa-bb54-456b-8f88-6b5bc52064ca%40app.fastmail.com

That case was correctly handled in v17 and before.

			regards, tom lane





view thread (6+ messages)  latest in thread

Message-ID: <271338.1767388841@sss.pgh.pa.us>
Permalink:  ../271338.1767388841@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/271338.1767388841@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, rguo@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Ignore PlaceHolderVars when looking up statistics
  In-Reply-To: <271338.1767388841@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox