pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Detect double-release of spinlock
Date: Mon, 29 Jul 2024 13:57:02 -0400
Message-ID: <2812470.1722275822@sss.pgh.pa.us> (raw)
In-Reply-To: <20240729174853.uo5qjqkxlacjg6vv@awork3.anarazel.de>
References: <E1sYSF2-001lEB-D1@gemulon.postgresql.org>
	<2600757.1722267116@sss.pgh.pa.us>
	<20240729161846.kgiafbe2dtgabxgb@awork3.anarazel.de>
	<2802449.1722270793@sss.pgh.pa.us>
	<20240729164026.yurg37tej34o76uk@awork3.anarazel.de>
	<20240729165154.56zqyg34x2ywkpsh@awork3.anarazel.de>
	<e8d4ef94-b8aa-4cda-8f31-081f78194275@iki.fi>
	<2809049.1722273922@sss.pgh.pa.us>
	<20240729174853.uo5qjqkxlacjg6vv@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> However, I still don't think it's a problem to assert that the lock is held in
> in the unlock "routine". As mentioned before, the spinlock implementation
> itself has never followed the "just straight line code" rule that users of
> spinlocks are supposed to follow.

Yeah, that's fair.

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <2812470.1722275822@sss.pgh.pa.us>
Permalink:  ../2812470.1722275822@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2812470.1722275822@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, hlinnaka@iki.fi, pgsql-hackers@postgresql.org
  Subject: Re: Detect double-release of spinlock
  In-Reply-To: <2812470.1722275822@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox