From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: Fri, 03 Jan 2020 13:17:53 -0500
Message-ID: <28562.1578075473@sss.pgh.pa.us> (raw)
In-Reply-To: <20200103174839.GD32629@msg.df7cb.de>
References: <20200103170226.GB32629@msg.df7cb.de>
<26339.1578072930@sss.pgh.pa.us>
<20200103174839.GD32629@msg.df7cb.de>
Christoph Berg <myon@debian.org> writes:
> Re: Tom Lane 2020-01-03 <26339.1578072930@sss.pgh.pa.us>
>> You do? I went looking in the Debian package source repo just the
>> other day for some evidence that that was true, and couldn't find
>> any, so I concluded that it was only an urban legend. Where is that
>> done exactly?
> /usr/share/postgresql-common/pg_wrapper
> https://salsa.debian.org/postgresql/postgresql-common/blob/master/pg_wrapper#L129-157
Oh, so not in the Postgres package per se.
What that means is that our regression tests will pass (as it's
just a regular libedit install while they're running) but then filename
completion will not work well for actual users. And there's not really
anything I can do about that from this end.
(On the other hand, filename completion is already kind of buggy,
which is why that patch exists in the first place. So maybe it
won't get any worse. Hard to say.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, myon@debian.org, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
In-Reply-To: <28562.1578075473@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox