From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: Tue, 07 Jan 2020 17:28:57 -0500
Message-ID: <28773.1578436137@sss.pgh.pa.us> (raw)
In-Reply-To: <19973.1578351988@sss.pgh.pa.us>
References: <E1in6ft-0004zR-6l@gemulon.postgresql.org>
<20200103110128.GA28967@msg.df7cb.de>
<13708.1578059577@sss.pgh.pa.us>
<25771.1578249042@sss.pgh.pa.us>
<20200106105608.GB18560@msg.df7cb.de>
<3764.1578323719@sss.pgh.pa.us>
<20200106191303.GA3975@msg.df7cb.de>
<19973.1578351988@sss.pgh.pa.us>
I wrote:
> I installed libedit_3.1-20150325.orig.tar.gz from source here, and it
> passes our current regression test and seems to behave just fine in
> light manual testing. (I did not apply any of the Debian-specific
> patches at [1], but they don't look like they'd explain much.)
> So I'm a bit at a loss as to what's going wrong for you. Is the test
> environment for Xenial the same as for the other branches?
To dig deeper, I set up an actual installation of xenial, and on that
I can replicate the tab-completion misbehavior you reported. The cause
appears to be that libedit's rl_line_buffer does not contain the current
line as expected, but the previous line (or, initially, an empty string).
Thus, the hack I put in to make things pass on current libedit actually
makes things worse on this version --- although it doesn't fully pass
even if I revert ddd87d564, since there are other places where we
depend on rl_line_buffer to be valid.
So that raises the question: why does xenial's version of libedit
not match either its documentation or the distributed source code?
Because it doesn't.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, myon@debian.org, andres@anarazel.de, amit.kapila16@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
In-Reply-To: <28773.1578436137@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox