From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.
Date: Fri, 07 Apr 2023 10:00:23 -0400
Message-ID: <2929174.1680876023@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfdv+10Uk6FWjsh3+ju7kHYr76LaRXbYayXmrM7FBU-=Hgg@mail.gmail.com>
References: <E1pkTFl-001hzA-LR@gemulon.postgresql.org>
<CAPpHfdv+10Uk6FWjsh3+ju7kHYr76LaRXbYayXmrM7FBU-=Hgg@mail.gmail.com>
Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Thu, Apr 6, 2023 at 8:18 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> psql: add an optional execution-count limit to \watch.
> This commit makes tests fail for me. psql parses 'i' option of
> '\watch' using locale-aware strtod(), but 001_basic.pl uses hard-coded
> decimal separator.
Huh, yeah, I see it too if I set LANG=ru_RU.utf8 before running psql's
TAP tests. It seems unfortunate that none of the buildfarm has noticed
this. I guess all the TAP tests are run under C locale?
> The proposed fix is attached.
LGTM, will push in a bit (unless you want to?)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, aekorotkov@gmail.com, andrew@dunslane.net
Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.
In-Reply-To: <2929174.1680876023@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox