From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Dave Page <dpage@postgresql.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv
Date: Sun, 19 Mar 2017 17:40:22 -0400
Message-ID: <2970.1489959622@sss.pgh.pa.us> (raw)
In-Reply-To: <c4350683-434f-750f-1eea-73f58e3450e8@iki.fi>
References: <E1coo2A-0004wP-SM@gemulon.postgresql.org>
<16609.1489773427@sss.pgh.pa.us>
<c4350683-434f-750f-1eea-73f58e3450e8@iki.fi>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 03/17/2017 07:57 PM, Tom Lane wrote:
>> This seems to have broken narwhal:
> It's not very nice to change the requirements in a minor version, but I
> don't think this would be a real problem for anyone. Not many people
> build PostgreSQL using MinGW, let alone with an ancient version of it.
> But if people don't agree, we could instead revert this patch and apply
> the smaller V2 patch [2] instead, in the back-branches.
> Thoughts? Any objections to requiring a newer version of MinGW? Any
> objections to do so in the next minor release?
Hm. I'm +1 for doing that in HEAD, but less so for the back branches.
Can we get some fix on when the functions in question were added
to MinGW? If we knew how new a toolchain we'd be requiring here,
that would help make this decision.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, hlinnaka@iki.fi, dpage@postgresql.org, pgsql-hackers@postgresql.org
Subject: Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv
In-Reply-To: <2970.1489959622@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox