From: Peter Eisentraut <peter@eisentraut.org>
To: Bruce Momjian <bruce@momjian.us>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: improve build for non-Latin1 characters
Date: Mon, 4 Nov 2024 08:02:18 +0100
Message-ID: <2c5dd601-b245-4092-9c27-6d1ad51609df@eisentraut.org> (raw)
In-Reply-To: <E1t6unt-003TTk-62@gemulon.postgresql.org>
References: <E1t6unt-003TTk-62@gemulon.postgresql.org>
I'm surprised this was committed. I don't think there was consensus
that this is the right direction. Moreover, this touched a couple of
files that it shouldn't have:
doc/src/sgml/images/genetic-algorithm.svg is a generated file that
shouldn't be changed directly. In fact, adding the *.svg files to the
check-nbsp target is therefore also wrong.
The chunk in doc/src/sgml/stylesheet-man.xsl was copied from the
upstream stylesheets, and changing it causes extra differences that
would make future maintenance harder. Also, man stylesheets have by
definition nothing to do with the pdf builds, so why do they need to be
touched?
I continue to think the whole premise of this patch is wrong.
On 01.11.24 17:47, Bruce Momjian wrote:
> doc: improve build for non-Latin1 characters
>
> Add README.non-ASCII to explain non-ASCII doc behavior; some text moved
> from release.sgml.
>
> Change UTF8 SGML characters to use HTML entities.
>
> Remove unnecessary UTF8 spaces.
>
> Add SVG file check for check-nbsp target.
>
> Add dummy 'pdf' Makefile target.
>
> Reported-by: Yugo Nagata
>
> Discussion: https://postgr.es/m/20241011114122.c90f8a871462da36f2e2afeb@sraoss.co.jp
>
> Backpatch-through: master
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/641a5b7a1447954076728f259342c2f9201bb0b5
>
> Modified Files
> --------------
> doc/src/sgml/Makefile | 11 ++++-----
> doc/src/sgml/README.non-ASCII | 37 +++++++++++++++++++++++++++++++
> doc/src/sgml/charset.sgml | 10 ++++-----
> doc/src/sgml/images/genetic-algorithm.svg | 4 ++--
> doc/src/sgml/release.sgml | 18 ---------------
> doc/src/sgml/stylesheet-man.xsl | 12 +++++-----
> 6 files changed, 56 insertions(+), 36 deletions(-)
>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, bruce@momjian.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: improve build for non-Latin1 characters
In-Reply-To: <2c5dd601-b245-4092-9c27-6d1ad51609df@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox