From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Date: Wed, 8 Dec 2021 10:56:46 -0500
Message-ID: <2e118a11-6936-21ec-6782-e9dbb20972c2@dunslane.net> (raw)
In-Reply-To: <3655283.1638977975@sss.pgh.pa.us>
References: <E1muynv-0006GS-R4@gemulon.postgresql.org>
<3655283.1638977975@sss.pgh.pa.us>
On 12/8/21 10:39, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Check that we have a working tar before trying to use it
> I don't like the way you did this:
>
> + || system_log($tar, '--version') != 0);
>
> ISTM that effectively restricts the test to only running
> on machines with GNU tar, which basically removes all the
> interest of it. We know what GNU tar does ... it's the
> weird legacy tar versions that might teach us something.
> See 57b5a9646 for a recent example of the sort of bug
> this test can no longer find.
>
>
I tested on a freebsd system before I did this for that reason. It's not
using GNU tar:
user@freebsd:~ $ tar --version
bsdtar 3.5.1 - libarchive 3.5.1 zlib/1.2.11 liblzma/5.2.5 bz2lib/1.0.8
Do you have an alternative test we could use? This is almost exactly
what we use to test for lz4.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
In-Reply-To: <2e118a11-6936-21ec-6782-e9dbb20972c2@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox