From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
Date: Mon, 21 Nov 2022 13:08:58 -0500
Message-ID: <3219281.1669054138@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoaYMUv1ab2vAh7AoSUqUYHtPx9Cmehue2=JCXO3gvsDbw@mail.gmail.com>
References: <E1ox94a-000EHu-VH@gemulon.postgresql.org>
<20221121172206.h6kywxrzqcmhoqom@awork3.anarazel.de>
<3214376.1669051457@sss.pgh.pa.us>
<3215927.1669052115@sss.pgh.pa.us>
<CA+TgmoaYMUv1ab2vAh7AoSUqUYHtPx9Cmehue2=JCXO3gvsDbw@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Nov 21, 2022 at 12:35 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hmm, so the problem is:
>>
>> SELECT octet_length(get_raw_page('test1', 'main', 0)) AS main_0;
>> ERROR: cannot access temporary tables during a parallel operation
>>
>> Why in the world is get_raw_page() marked as parallel safe?
>> It clearly isn't, given this restriction.
> I suspect that restriction was overlooked when evaluating the marking
> of this function.
So it would seem. PARALLEL RESTRICTED should work, though.
I'll check to see if any sibling functions have the same issue,
and push a patch to adjust them.
Presumably the parallel labeling has to be fixed as far back as
it's marked that way (didn't look). Maybe we should push the
test change further back too, just to exercise this.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
In-Reply-To: <3219281.1669054138@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox