pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
Date: Mon, 21 Nov 2022 15:33:51 -0500
Message-ID: <3267209.1669062831@sss.pgh.pa.us> (raw)
In-Reply-To: <20221121201818.u32xtvpqc5wd6tx7@alap3.anarazel.de>
References: <E1ox94a-000EHu-VH@gemulon.postgresql.org>
	<20221121172206.h6kywxrzqcmhoqom@awork3.anarazel.de>
	<3214376.1669051457@sss.pgh.pa.us>
	<3215927.1669052115@sss.pgh.pa.us>
	<CA+TgmoaYMUv1ab2vAh7AoSUqUYHtPx9Cmehue2=JCXO3gvsDbw@mail.gmail.com>
	<20221121195628.2rlqpbkjgjsvqn6w@alap3.anarazel.de>
	<3264594.1669061535@sss.pgh.pa.us>
	<20221121201818.u32xtvpqc5wd6tx7@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-11-21 15:12:15 -0500, Tom Lane wrote:
>> If I were trying to find a better fix I'd be looking for ways for
>> parallel workers to be able to read the parent's temp tables.
>> (Perhaps that could tie in with the blue-sky discussion we had
>> the other day about allowing autovacuum on temp tables??)

> That'd be a nontrivial change, because we explicitly don't use any
> locking for anything relating to localbuf.c. One possible benefit could
> be that we could substantially reduce the code duplication between
> "normal" bufmgr.c and localbuf.c.

I didn't say this was easy ;-).  Aside from locking, the local buffers
are inside the process's address space and not accessible from outside.
Maybe they could be mapped into a shared memory region instead?
And there are optimizations like commit a7212be8b that depend on the
assumption that nothing else is accessing our process's temp tables.
That'd need a lot of thought, if we don't want to give up all the
performance benefits of temp tables.

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <3267209.1669062831@sss.pgh.pa.us>
Permalink:  ../3267209.1669062831@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3267209.1669062831@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
  In-Reply-To: <3267209.1669062831@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox