From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: nasbyj@amazon.com, Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru
Date: Tue, 02 Oct 2018 10:15:28 -0400
Message-ID: <338.1538489728@sss.pgh.pa.us> (raw)
In-Reply-To: <20181002065508.GC17642@paquier.xyz>
References: <23209391537822541@iva4-6d7004ac8463.qloud-c.yandex.net>
<20180924211117.tpwxemzd3372nagj@alvherre.pgsql>
<CAD21AoAV17jQH6__E8_VQePms4NptX0X50U=98qJ5RNV7au1iw@mail.gmail.com>
<20181002001151.GP11712@paquier.xyz>
<CAD21AoB-nhVxo=6__BeukNniHnt6UGMKRs3v=Zkn-WJq9kx+4A@mail.gmail.com>
<20181002065508.GC17642@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> My brain is rather fried for the rest of the day... But we could just
> be looking at using USE_ASSERT_CHECKING. Thoughts from other are
> welcome.
I'd go with folding the condition into a plain Assert. Then it's
obvious that no code is added in a non-assert build. I can see that
some cases might be so complicated that that isn't nice, but this
case doesn't seem to qualify.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, sawada.mshk@gmail.com, alvherre@2ndquadrant.com, sk@zsrv.org, andres@anarazel.de, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru
In-Reply-To: <338.1538489728@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox