pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining
Date: Sun, 19 Nov 2023 21:08:24 +0100
Message-ID: <3469A042-A3EB-4483-831D-0D8815D4EF41@yesql.se> (raw)
In-Reply-To: <1106876.1700409912@sss.pgh.pa.us>
References: <E1r3wSk-005s3g-JI@gemulon.postgresql.org>
	<1106876.1700409912@sss.pgh.pa.us>

> On 19 Nov 2023, at 17:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <dgustafsson@postgresql.org> writes:
>> llvmjit: Use explicit LLVMContextRef for inlining
> 
> It looks like the v12 back-port of this wasn't quite right:
> canebrake and urutu have both been showing assertion failures
> down inside LLVMContextDispose since it went in.  They aren't
> complaining about v13 and later, though.

Ugh, I had missed these =/ Thanks for the heads up!

> No idea what the cause may be, but perhaps the right answer
> is just to revert this and not try to fix the bug in v12?

I'll have a look with fresh eyes in the morning, and hopefully it will be
fixable.  If it get's messy it's quite possible that skipping v12 is the best
option.

--
Daniel Gustafsson






view thread (11+ messages)  latest in thread

Message-ID: <3469A042-A3EB-4483-831D-0D8815D4EF41@yesql.se>
Permalink:  ../3469A042-A3EB-4483-831D-0D8815D4EF41@yesql.se/
Also on:    postgresql.org/message-id/3469A042-A3EB-4483-831D-0D8815D4EF41@yesql.se

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: daniel@yesql.se, tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining
  In-Reply-To: <3469A042-A3EB-4483-831D-0D8815D4EF41@yesql.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox