From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add assert checking to pg_leftmost_one_pos32() and friends
Date: Mon, 20 Feb 2023 10:17:41 -0500
Message-ID: <3567481.1676906261@sss.pgh.pa.us> (raw)
In-Reply-To: <E1pU0gM-0023El-EL@gemulon.postgresql.org>
References: <E1pU0gM-0023El-EL@gemulon.postgresql.org>
John Naylor <john.naylor@postgresql.org> writes:
> Add assert checking to pg_leftmost_one_pos32() and friends
I can see that this was worth writing for testing purposes, but
is it really worth carrying permanently? Even in a debug build,
the ratio of cycles expended to chances of finding a problem seems
mighty poor, and you've done a lot of damage to the readability
of these functions too.
Maybe we could condition the duplicate computation on some
additional not-commonly-defined macro? That'd do little for the
readability issue though.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, john.naylor@postgresql.org
Subject: Re: pgsql: Add assert checking to pg_leftmost_one_pos32() and friends
In-Reply-To: <3567481.1676906261@sss.pgh.pa.us>
References: <E1pU0gM-0023El-EL@gemulon.postgresql.org> <3567481.1676906261@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox