pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow tailoring of ICU locales with custom rules
Date: Wed, 08 Mar 2023 12:57:29 -0800
Message-ID: <36a6e89689716c2ca1fae8adc8e84601a041121c.camel@j-davis.com> (raw)
In-Reply-To: <E1pZwGA-002X1G-4w@gemulon.postgresql.org>
References: <E1pZwGA-002X1G-4w@gemulon.postgresql.org>

On Wed, 2023-03-08 at 16:03 +0000, Peter Eisentraut wrote:
> Allow tailoring of ICU locales with custom rules

Late review:

* Should throw error when provider != icu and rules != NULL

* Explain what the example means. By itself, users might get confused
wondering why someone would want to do that.

* Also consider a more practical example?

* It appears rules IS NULL behaves differently from rules=''. Is that
desired? For instance:
  create collation c1(provider=icu,
    locale='und-u-ka-shifted-ks-level1',
    deterministic=false);
  create collation c2(provider=icu,
    locale='und-u-ka-shifted-ks-level1',
    rules='',
    deterministic=false);
  select 'a b' collate c1 = 'ab' collate c1; -- true
  select 'a b' collate c2 = 'ab' collate c2; -- false

* Can you document the interaction between locale keywords
("@colStrength=primary") and a rule like '[strength 2]'?

Regards,
	Jeff Davis






view thread (7+ messages)  latest in thread

Message-ID: <36a6e89689716c2ca1fae8adc8e84601a041121c.camel@j-davis.com>
Permalink:  ../36a6e89689716c2ca1fae8adc8e84601a041121c.camel@j-davis.com/
Also on:    postgresql.org/message-id/36a6e89689716c2ca1fae8adc8e84601a041121c.camel@j-davis.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: pgsql@j-davis.com, peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Allow tailoring of ICU locales with custom rules
  In-Reply-To: <36a6e89689716c2ca1fae8adc8e84601a041121c.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox