From: Daniel Gustafsson <daniel@yesql.se>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Clean up role created in new subscription test.
Date: Wed, 8 Nov 2023 13:24:41 +0100
Message-ID: <3B08E3F2-37C8-4D26-BA80-C4C0F4DF3848@yesql.se> (raw)
In-Reply-To: <202311081142.znnn3kgehvqo@alvherre.pgsql>
References: <202311081142.znnn3kgehvqo@alvherre.pgsql>
> On 8 Nov 2023, at 12:42, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2023-Nov-08, Peter Eisentraut wrote:
>> I think the earlier idea of just counting roles, tablespaces, etc. before
>> and after would be sufficient.
>
> Maybe record global objects in a permanent table in test_setup.sql
Since test_setup.sql is part of the regress schedule and not pg_regress we
would have to implement this for each test run (regress, contribs etc), which
is what Peter didn't like about the original suggestion.
--
Daniel Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, alvherre@alvh.no-ip.org, peter@eisentraut.org, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Clean up role created in new subscription test.
In-Reply-To: <3B08E3F2-37C8-4D26-BA80-C4C0F4DF3848@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox