From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Small tidyup for commit d41a178b.
Date: Thu, 16 Mar 2023 20:36:28 -0400
Message-ID: <4040668.1679013388@sss.pgh.pa.us> (raw)
In-Reply-To: <E1pcvR8-003sWl-1i@gemulon.postgresql.org>
References: <E1pcvR8-003sWl-1i@gemulon.postgresql.org>
Thomas Munro <tmunro@postgresql.org> writes:
> Small tidyup for commit d41a178b.
> A comment was left behind claiming that we needed to use malloc() rather
> than palloc() because the corresponding free would run in another
> thread, but that's not true anymore. Remove that comment. And, with
> the reason being gone, we might as well actually use palloc().
Hm, doesn't the change to palloc make the following error check redundant?
childinfo = palloc(sizeof(win32_deadchild_waitinfo));
- if (!childinfo)
- ereport(FATAL,
- (errcode(ERRCODE_OUT_OF_MEMORY),
- errmsg("out of memory")));
-
childinfo->procHandle = pi.hProcess;
childinfo->procId = pi.dwProcessId;
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Small tidyup for commit d41a178b.
In-Reply-To: <4040668.1679013388@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox