From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Remove unused wait events.
Date: Mon, 25 Oct 2021 12:38:38 -0400
Message-ID: <4047667.1635179918@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoYSAsxiHqpyDCzJa2-hYv0Sme7Me1esi6sHG6LbY8KD+w@mail.gmail.com>
References: <E1mdOBY-0005j2-QL@gemulon.postgresql.org>
<CA+TgmoYSAsxiHqpyDCzJa2-hYv0Sme7Me1esi6sHG6LbY8KD+w@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Oct 20, 2021 at 10:52 PM Amit Kapila <akapila@postgresql.org> wrote:
>> Remove unused wait events.
> This commit forces a recompile of every extension that knows about the
> integer values assigned to the enums in WaitEventIO. I know of 2
> extensions that are affected by this. I think that it should be
> reverted in v14 and kept only in master.
Um ... the removed symbols were at the end of the WaitEventIO enum,
so is there really an ABI break? I suppose if an extension contains
actual references to the removed symbols, it would fail to recompile,
which'd be annoying for a released branch.
On the whole, I agree that this patch had no business being committed
to v14.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, akapila@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Remove unused wait events.
In-Reply-To: <4047667.1635179918@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox