From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org, Amit Langote <amitlangote09@gmail.com>
Subject: Re: pgsql: Remove some dead code in selfuncs.c
Date: Thu, 19 Jan 2023 11:43:47 -0500
Message-ID: <4069769.1674146627@sss.pgh.pa.us> (raw)
In-Reply-To: <4063400.1674143134@sss.pgh.pa.us>
References: <E1pITe3-004ReV-5B@gemulon.postgresql.org>
<4063400.1674143134@sss.pgh.pa.us>
I wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>> Remove some dead code in selfuncs.c
>> RelOptInfo.userid is the same for all relations in a given inheritance
>> tree, so the code in examine_variable() and example_simple_variable()
>> that repeats the ACL checks on the root parent rel instead of a given
>> leaf child relations need not recompute userid too.
> This change seems rather ill-advised.
Ah, sorry, -ENOCAFFEINE. It's talking about the access-as-user field,
not the relation's owner. I agree that as querytrees are currently
built, this is probably a safe optimization. But do we really want
to hard-wire such a subtle assumption to gain a microscopic speed
benefit? It's not as though GetUserId() is expensive.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, amitlangote09@gmail.com
Subject: Re: pgsql: Remove some dead code in selfuncs.c
In-Reply-To: <4069769.1674146627@sss.pgh.pa.us>
References: <E1pITe3-004ReV-5B@gemulon.postgresql.org> <4063400.1674143134@sss.pgh.pa.us> <4069769.1674146627@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox