pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
11+ messages / 4 participants
[nested] [flat]

Commits from this thread:
  2022-01-19 0f47e833bf  Fix alignment problem with bbsink_copystream buffer.
* pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
@ 2022-01-18 18:50 Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  0 siblings, 1 reply; 11+ messages in thread

From: Robert Haas @ 2022-01-18 18:50 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Modify pg_basebackup to use a new COPY subprotocol for base backups.

In the new approach, all files across all tablespaces are sent in a
single COPY OUT operation. The CopyData messages are no longer raw
archive content; rather, each message is prefixed with a type byte
that describes its purpose, e.g. 'n' signifies the start of a new
archive and 'd' signifies archive or manifest data. This protocol
is significantly more extensible than the old approach, since we can
later create more message types, though not without concern for
backward compatibility.

The new protocol sends a few things to the client that the old one
did not. First, it sends the name of each archive explicitly, instead
of letting the client compute it. This is intended to make it easier
to write future patches that might send archives in a format other
that tar (e.g. cpio, pax, tar.gz). Second, it sends explicit progress
messages rather than allowing the client to assume that progress is
defined by the number of bytes received. This will help with future
features where the server compresses the data, or sends it someplace
directly rather than transmitting it to the client.

The old protocol is still supported for compatibility with previous
releases. The new protocol is selected by means of a new
TARGET option to the BASE_BACKUP command. Currently, the
only supported target is 'client'. Support for additional
targets will be added in a later commit.

Patch by me. The patch set of which this is a part has had review
and/or testing from Jeevan Ladhe, Tushar Ahuja, Suraj Kharage,
Dipesh Pandit, and Mark Dilger.

Discussion: http://postgr.es/m/CA+TgmoaYZbz0=Yk797aOJwkGJC-LK3iXn+wzzMx7KdwNpZhS5g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cc333f32336f5146b75190f57ef587dff225f565

Modified Files
--------------
doc/src/sgml/protocol.sgml                | 130 +++++++++-
src/backend/replication/basebackup.c      |  36 ++-
src/backend/replication/basebackup_copy.c | 277 +++++++++++++++++++-
src/bin/pg_basebackup/pg_basebackup.c     | 410 +++++++++++++++++++++++++++---
src/include/replication/basebackup_sink.h |   1 +
5 files changed, 806 insertions(+), 48 deletions(-)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
@ 2022-01-18 20:54 ` Robert Haas <robertmhaas@gmail.com>
  2022-01-18 21:36   ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
  2022-01-18 22:12   ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 2 replies; 11+ messages in thread

From: Robert Haas @ 2022-01-18 20:54 UTC (permalink / raw)
  To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>; Tom Lane <tgl@sss.pgh.pa.us>

On Tue, Jan 18, 2022 at 1:51 PM Robert Haas <rhaas@postgresql.org> wrote:
> Modify pg_basebackup to use a new COPY subprotocol for base backups.

Andres pointed out to me that longfin is sad:

2022-01-18 14:52:35.484 EST [82470:4] LOG:  server process (PID 82487)
was terminated by signal 4: Illegal instruction: 4
2022-01-18 14:52:35.484 EST [82470:5] DETAIL:  Failed process was
running: BASE_BACKUP ( LABEL 'pg_basebackup base backup',  PROGRESS,
CHECKPOINT 'fast',  MANIFEST 'yes',  TARGET 'client')

Unfortunately, I can't reproduce this locally, even with COPT=-Wall
-Werror -fno-omit-frame-pointer -fsanitize-trap=alignment
-Wno-deprecated-declarations -DWRITE_READ_PARSE_PLAN_TREES
-DSTRESS_SORT_INT_MIN -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS.

Tom, any chance you can get a stack trace?

--
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
@ 2022-01-18 21:36   ` Tom Lane <tgl@sss.pgh.pa.us>
  2022-01-18 21:58     ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-18 22:06     ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
  1 sibling, 2 replies; 11+ messages in thread

From: Tom Lane @ 2022-01-18 21:36 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Robert Haas <robertmhaas@gmail.com> writes:
> Andres pointed out to me that longfin is sad:

> 2022-01-18 14:52:35.484 EST [82470:4] LOG:  server process (PID 82487)
> was terminated by signal 4: Illegal instruction: 4

> Tom, any chance you can get a stack trace?

Hmm, I'd assumed that was just a cosmic ray or something.
I'll check if it reproduces, though.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-18 21:36   ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-01-18 21:58     ` Robert Haas <robertmhaas@gmail.com>
  1 sibling, 0 replies; 11+ messages in thread

From: Robert Haas @ 2022-01-18 21:58 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Tue, Jan 18, 2022 at 4:36 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > Andres pointed out to me that longfin is sad:
>
> > 2022-01-18 14:52:35.484 EST [82470:4] LOG:  server process (PID 82487)
> > was terminated by signal 4: Illegal instruction: 4
>
> > Tom, any chance you can get a stack trace?
>
> Hmm, I'd assumed that was just a cosmic ray or something.
> I'll check if it reproduces, though.

Thomas pointed out to me that thorntail also failed, and that it
included a backtrace. Unfortunately it's not somewhat confusing. The
innermost frame is:

#0  0x00000100006319a4 in bbsink_archive_contents (len=<optimized
out>, sink=<optimized out>) at
/home/nm/farm/sparc64_deb10_gcc_64_ubsan/HEAD/pgsql.build/../pgsql/src/backend/replication/basebackup.c:1672
1672 return true;

Line 1672 of basebackup.c  is indeed "return true" but we're inside of
sendFile(), not bbsink_archive_contents(). However,
bbsink_archive_contents() is an inline function so maybe the failure
is misattributed. I wonder whether the "sink" pointer in that function
is somehow not valid ... but I don't know how that would happen, or
why it would happen only on this machine.

-- 
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-18 21:36   ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-01-18 22:06     ` Tom Lane <tgl@sss.pgh.pa.us>
  1 sibling, 0 replies; 11+ messages in thread

From: Tom Lane @ 2022-01-18 22:06 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

I wrote:
>> Tom, any chance you can get a stack trace?

> Hmm, I'd assumed that was just a cosmic ray or something.

My mistake: it's failing because of -fsanitize=alignment.

Here's the stack trace:

  * frame #0: 0x000000010885dfd0 postgres`sendFile(sink=0x00007fdedf071cb0, readfilename="./global/4178", tarfilename="global/4178", statbuf=0x00007ffee77dfaf8, missing_ok=true, dboid=0, manifest=0x00007ffee77e2780, spcoid=0x0000000000000000) at basebackup.c:1552:10
    frame #1: 0x000000010885cb7f postgres`sendDir(sink=0x00007fdedf071cb0, path="./global", basepathlen=1, sizeonly=false, tablespaces=0x00007fdedf072718, sendtblspclinks=true, manifest=0x00007ffee77e2780, spcoid=0x0000000000000000) at basebackup.c:1354:12
    frame #2: 0x000000010885ca6b postgres`sendDir(sink=0x00007fdedf071cb0, path=".", basepathlen=1, sizeonly=false, tablespaces=0x00007fdedf072718, sendtblspclinks=true, manifest=0x00007ffee77e2780, spcoid=0x0000000000000000) at basebackup.c:1346:13
    frame #3: 0x00000001088595be postgres`perform_base_backup(opt=0x00007ffee77e2e68, sink=0x00007fdedf071cb0) at basebackup.c:352:5
    frame #4: 0x0000000108856b0b postgres`SendBaseBackup(cmd=0x00007fdedf05b510) at basebackup.c:932:3
    frame #5: 0x00000001088711c8 postgres`exec_replication_command(cmd_string="BASE_BACKUP ( LABEL 'pg_basebackup base backup',  PROGRESS,  CHECKPOINT 'fast',  MANIFEST 'yes',  TARGET 'client')") at walsender.c:1734:4 [opt]
    frame #6: 0x00000001088dd61e postgres`PostgresMain(dbname=<unavailable>, username=<unavailable>) at postgres.c:4494:12 [opt]

It failed at

-> 1552                                 if (!PageIsNew(page) && PageGetLSN(page) < sink->bbs_state->startptr)

and the problem is evidently that the page pointer isn't nicely aligned:

(lldb) p page
(char *) $4 = 0x00007fdeded7e041 ""

(I checked the "sink" data structure too for luck, but it seems fine.)

I see that thorntail has now also fallen over, presumably for
the same reason.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
@ 2022-01-18 22:12   ` Tom Lane <tgl@sss.pgh.pa.us>
  2022-01-19 01:49     ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Andres Freund <andres@anarazel.de>
  2022-01-19 01:55     ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  1 sibling, 2 replies; 11+ messages in thread

From: Tom Lane @ 2022-01-18 22:12 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Robert Haas <robertmhaas@gmail.com> writes:
> Unfortunately, I can't reproduce this locally, even with COPT=-Wall
> -Werror -fno-omit-frame-pointer -fsanitize-trap=alignment
> -Wno-deprecated-declarations -DWRITE_READ_PARSE_PLAN_TREES
> -DSTRESS_SORT_INT_MIN -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS.

Now that I re-read what you did, I believe you need both of

-fsanitize=alignment -fsanitize-trap=alignment

to enable those traps to happen.  That seems to be the case with
Apple's clang, anyway.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-18 22:12   ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-01-19 01:49     ` Andres Freund <andres@anarazel.de>
  1 sibling, 0 replies; 11+ messages in thread

From: Andres Freund @ 2022-01-19 01:49 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Robert Haas <robertmhaas@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On 2022-01-18 17:12:00 -0500, Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > Unfortunately, I can't reproduce this locally, even with COPT=-Wall
> > -Werror -fno-omit-frame-pointer -fsanitize-trap=alignment
> > -Wno-deprecated-declarations -DWRITE_READ_PARSE_PLAN_TREES
> > -DSTRESS_SORT_INT_MIN -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS.
>
> Now that I re-read what you did, I believe you need both of
>
> -fsanitize=alignment -fsanitize-trap=alignment
>
> to enable those traps to happen.  That seems to be the case with
> Apple's clang, anyway.

FWIW, I can reproduce it on linux, but only if I -fno-sanitize-recover instead
of -fsanitize-trap=alignment. That then also produces a nicer explanation of
the problem:

/home/andres/src/postgresql/src/backend/replication/basebackup.c:1552:10: runtime error: member access within misaligned address 0x000002b9ce09 for type 'PageHeaderData' (aka 'struct PageHeaderData'), which requires 4 byte alignment
0x000002b9ce09: note: pointer points here
 00 00 00  64 00 00 00 00 c8 ad 0c  01 c5 1b 00 00 48 00 f0  1f f0 1f 04 20 00 00 00  00 62 31 05 00
              ^
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/andres/src/postgresql/src/backend/replication/basebackup.c:1552:10 in
2022-01-18 17:36:17.746 PST [1448756] LOG:  server process (PID 1448774) exited with exit code 1
2022-01-18 17:36:17.746 PST [1448756] DETAIL:  Failed process was running: BASE_BACKUP ( LABEL 'pg_basebackup base backup',  PROGRESS,  CHECKPOINT 'fast',  MANIFEST 'yes',  TARGET 'client')

The problem originates in bbsink_copystream_begin_backup()...

Greetings,

Andres Freund





^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-18 22:12   ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-01-19 01:55     ` Robert Haas <robertmhaas@gmail.com>
  2022-01-19 02:23       ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  1 sibling, 1 reply; 11+ messages in thread

From: Robert Haas @ 2022-01-19 01:55 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Tue, Jan 18, 2022 at 5:12 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Now that I re-read what you did, I believe you need both of
>
> -fsanitize=alignment -fsanitize-trap=alignment
>
> to enable those traps to happen.  That seems to be the case with
> Apple's clang, anyway.

Ah, I guess I copied and pasted the options wrong, or something.
Anyway, I have an idea how to fix this. I didn't realize that we were
going to read from the bbsink's buffer like this, and it's not
properly aligned for that. I'll jigger things around to fix that.

-- 
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-18 22:12   ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
  2022-01-19 01:55     ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
@ 2022-01-19 02:23       ` Robert Haas <robertmhaas@gmail.com>
  2022-01-19 02:29         ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 11+ messages in thread

From: Robert Haas @ 2022-01-19 02:23 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Tue, Jan 18, 2022 at 8:55 PM Robert Haas <robertmhaas@gmail.com> wrote:
> Ah, I guess I copied and pasted the options wrong, or something.
> Anyway, I have an idea how to fix this. I didn't realize that we were
> going to read from the bbsink's buffer like this, and it's not
> properly aligned for that. I'll jigger things around to fix that.

Here's a patch. I'm still not able to reproduce the problem either
with the flags you propose (which don't cause a failure) or the ones
which Andres suggests (which make clang bitterly unhappy) or the ones
clang says I should use instead of the ones Andres suggests (which
make initdb fall over, so we never even get to the point of attempting
anything related to the code this patch modified).

Here's a patch, based in part on some off-list discussion with Andres.
I believe Andres has already confirmed that this fix works, but it
wouldn't hurt if Tom wants to verify it also.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Attachments:

align-buffer-more.patch (application/octet-stream, 1.7K) download diff --git a/src/backend/replication/basebackup_copy.c b/src/backend/replication/basebackup_copy.c index f42b368c03..8dfdff0644 100644 --- a/src/backend/replication/basebackup_copy.c +++ b/src/backend/replication/basebackup_copy.c @@ -152,18 +152,22 @@ bbsink_copystream_begin_backup(bbsink *sink) { bbsink_copystream *mysink = (bbsink_copystream *) sink; bbsink_state *state = sink->bbs_state; + char *buf; /* * Initialize buffer. We ultimately want to send the archive and manifest * data by means of CopyData messages where the payload portion of each - * message begins with a type byte, so we set up a buffer that begins with - * a the type byte we're going to need, and then arrange things so that - * the data we're given will be written just after that type byte. That - * will allow us to ship the data with a single call to pq_putmessage and - * without needing any extra copying. + * message begins with a type byte. However, basebackup.c expects the + * buffer to be aligned, so we can't just allocate one extra byte for the + * type byte. Instead, allocate enough extra bytes that the portion of + * the buffer we reveal to our callers can be aligned, while leaving room + * to slip the type byte in just beforehand. That will allow us to ship + * the data with a single call to pq_putmessage and without needing any + * extra copying. */ - mysink->msgbuffer = palloc(mysink->base.bbs_buffer_length + 1); - mysink->base.bbs_buffer = mysink->msgbuffer + 1; + buf = palloc(mysink->base.bbs_buffer_length + MAXIMUM_ALIGNOF); + mysink->msgbuffer = buf + (MAXIMUM_ALIGNOF - 1); + mysink->base.bbs_buffer = buf + MAXIMUM_ALIGNOF; mysink->msgbuffer[0] = 'd'; /* archive or manifest data */ /* Tell client the backup start location. */
^ permalink raw reply [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-18 22:12   ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
  2022-01-19 01:55     ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-19 02:23       ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
@ 2022-01-19 02:29         ` Tom Lane <tgl@sss.pgh.pa.us>
  2022-01-19 13:16           ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  0 siblings, 1 reply; 11+ messages in thread

From: Tom Lane @ 2022-01-19 02:29 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Robert Haas <robertmhaas@gmail.com> writes:
> Here's a patch, based in part on some off-list discussion with Andres.
> I believe Andres has already confirmed that this fix works, but it
> wouldn't hurt if Tom wants to verify it also.

WFM too --- at least, pg_basebackup's "make check" passes now.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back
  2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
  2022-01-18 20:54 ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-18 22:12   ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
  2022-01-19 01:55     ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-19 02:23       ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <robertmhaas@gmail.com>
  2022-01-19 02:29         ` Re: pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-01-19 13:16           ` Robert Haas <robertmhaas@gmail.com>
  0 siblings, 0 replies; 11+ messages in thread

From: Robert Haas @ 2022-01-19 13:16 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Tue, Jan 18, 2022 at 9:29 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > Here's a patch, based in part on some off-list discussion with Andres.
> > I believe Andres has already confirmed that this fix works, but it
> > wouldn't hurt if Tom wants to verify it also.
>
> WFM too --- at least, pg_basebackup's "make check" passes now.

Thanks for checking. Committed.

-- 
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 11+ messages in thread


end of thread, other threads:[~2022-01-19 13:16 UTC | newest]

Thread overview: 11+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-01-18 18:50 pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back Robert Haas <rhaas@postgresql.org>
2022-01-18 20:54 ` Robert Haas <robertmhaas@gmail.com>
2022-01-18 21:36   ` Tom Lane <tgl@sss.pgh.pa.us>
2022-01-18 21:58     ` Robert Haas <robertmhaas@gmail.com>
2022-01-18 22:06     ` Tom Lane <tgl@sss.pgh.pa.us>
2022-01-18 22:12   ` Tom Lane <tgl@sss.pgh.pa.us>
2022-01-19 01:49     ` Andres Freund <andres@anarazel.de>
2022-01-19 01:55     ` Robert Haas <robertmhaas@gmail.com>
2022-01-19 02:23       ` Robert Haas <robertmhaas@gmail.com>
2022-01-19 02:29         ` Tom Lane <tgl@sss.pgh.pa.us>
2022-01-19 13:16           ` Robert Haas <robertmhaas@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox