From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Test replay of regression tests, attempt II.
Date: Tue, 18 Jan 2022 17:19:06 -0500
Message-ID: <415981.1642544346@sss.pgh.pa.us> (raw)
In-Reply-To: <20220118204012.qpfas4fmvc55g4ei@alap3.anarazel.de>
References: <E1n9Io8-0007At-FQ@gemulon.postgresql.org>
<YeUUiruW+mqNNGIG@paquier.xyz>
<20220117203746.oj43254j5jurbneu@alap3.anarazel.de>
<CA+hUKGLT2UL5_JhmBzUgkdyKfc=5J-gJSQJLysMs4rqLUKLAzw@mail.gmail.com>
<CA+hUKGJDrokTTT3fAEESHiW5TmwxkkJGqe8bR-VFjpg4+hK+fQ@mail.gmail.com>
<374643.1642536944@sss.pgh.pa.us>
<20220118204012.qpfas4fmvc55g4ei@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> That's an extremely small shared_buffers for running the regression tests, it'd not
> be surprising if that provoked problems we don't otherwise see. Perhaps VACUUM
> ends up skipping over a page because of page contention?
Hmm, good thought. I tried running the test with even smaller
shared_buffers, but could not make the reloptions test fall over for
me. But this theory implies a strong timing dependency, so it might
still only happen on particular machines. (If anyone else tries it:
below about 400kB, other tests start failing with "no free unpinned
buffers" and the like.)
> Also, it's odd that there's "max_connections 25" without an equal sign. I'd
> kind of expected that to cause an error....
I see that guc.c intentionally allows the equal sign to be optional.
Too lazy to check if that's documented. It is weird that this one
test appears to be intentionally testing that, though, because it's
sure got nada to do with the expressed purpose of the test.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com, michael@paquier.xyz, tmunro@postgresql.org
Subject: Re: pgsql: Test replay of regression tests, attempt II.
In-Reply-To: <415981.1642544346@sss.pgh.pa.us>
References: <E1n9Io8-0007At-FQ@gemulon.postgresql.org> <YeUUiruW+mqNNGIG@paquier.xyz> <20220117203746.oj43254j5jurbneu@alap3.anarazel.de> <CA+hUKGLT2UL5_JhmBzUgkdyKfc=5J-gJSQJLysMs4rqLUKLAzw@mail.gmail.com> <CA+hUKGJDrokTTT3fAEESHiW5TmwxkkJGqe8bR-VFjpg4+hK+fQ@mail.gmail.com> <374643.1642536944@sss.pgh.pa.us> <20220118204012.qpfas4fmvc55g4ei@alap3.anarazel.de> <415981.1642544346@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox