From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Unstable tests for recovery conflict handling
Date: Wed, 27 Apr 2022 14:08:45 -0400
Message-ID: <447238.1651082925@sss.pgh.pa.us> (raw)
In-Reply-To: <394950.1651077914@sss.pgh.pa.us>
References: <E1nca5h-000nN0-6f@gemulon.postgresql.org>
<394950.1651077914@sss.pgh.pa.us>
I wrote:
> It's been kind of hidden by other buildfarm noise, but
> 031_recovery_conflict.pl is not as stable as it should be [1][2][3][4].
> ...
> I think this is showing us a real bug, ie we sometimes fail to cancel
> the conflicting query.
After digging around in the code, I think this is almost certainly
some manifestation of the previously-complained-of problem [1] that
RecoveryConflictInterrupt is not safe to call in a signal handler,
leading the conflicting backend to sometimes decide that it's not
the problem. That squares with the observation that skink is more
prone to show this than other animals: you'd have to get the SIGUSR1
while the target backend isn't idle, so a very slow machine ought to
show it more. We don't seem to have that issue on the open items
list, but I'll go add it.
Not sure if the 'buffer pin conflict: stats show conflict on standby'
failure could trace to a similar cause.
regards, tom lane
[1] https://www.postgresql.org/message-id/flat/CA%2BhUKGK3PGKwcKqzoosamn36YW-fsuTdOPPF1i_rtEO%3DnEYKSg%4...
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com, melanieplageman@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Unstable tests for recovery conflict handling
In-Reply-To: <447238.1651082925@sss.pgh.pa.us>
References: <E1nca5h-000nN0-6f@gemulon.postgresql.org> <394950.1651077914@sss.pgh.pa.us> <447238.1651082925@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox