pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma
2+ messages / 2 participants
[nested] [flat]

* pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma
@ 2022-06-15 06:41  Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 2+ messages in thread

From: Michael Paquier @ 2022-06-15 06:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Re-add locally-generated files in pg_upgrade's .gitignore and Makefile

This reverts the changes to pg_upgrade's Makefile and .gitignore done in
15b6d21.  The TAP tests run in isolation, executing pg_upgrade in
tmp_check/ in the build directory so as any files created in the
execution path (reindex_hash.sql and delete_old_cluster.{sh,bat}) are
never in the tree, so entries are not necessary in this case.  However,
not having these impacts the cleanliness of the code tree when running
./pg_upgrade directly from src/bin/pg_upgrade/.

This commit adds back to .gitignore all the files generated in the
execution path, and the Makefile rule to clean them up if they exist.

Per gripe from Tom Lane.

Discussion: https://postgr.es/m/90595.1655227384@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a059e15cdeef3e8de9a34de48c49c29d398bf4e8

Modified Files
--------------
src/bin/pg_upgrade/.gitignore | 4 ++++
src/bin/pg_upgrade/Makefile   | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma
@ 2022-06-15 15:55  Tom Lane <tgl@sss.pgh.pa.us>
  parent: Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-06-15 15:55 UTC (permalink / raw)
  To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org

Michael Paquier <michael@paquier.xyz> writes:
> Re-add locally-generated files in pg_upgrade's .gitignore and Makefile

Thanks.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-06-15 15:55 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 06:41 pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma Michael Paquier <michael@paquier.xyz>
2022-06-15 15:55 ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox