pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma
Date: Wed, 15 Jun 2022 06:41:34 +0000
Message-ID: <E1o1Mic-0008RL-Bz@gemulon.postgresql.org> (raw)

Re-add locally-generated files in pg_upgrade's .gitignore and Makefile

This reverts the changes to pg_upgrade's Makefile and .gitignore done in
15b6d21.  The TAP tests run in isolation, executing pg_upgrade in
tmp_check/ in the build directory so as any files created in the
execution path (reindex_hash.sql and delete_old_cluster.{sh,bat}) are
never in the tree, so entries are not necessary in this case.  However,
not having these impacts the cleanliness of the code tree when running
./pg_upgrade directly from src/bin/pg_upgrade/.

This commit adds back to .gitignore all the files generated in the
execution path, and the Makefile rule to clean them up if they exist.

Per gripe from Tom Lane.

Discussion: https://postgr.es/m/90595.1655227384@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a059e15cdeef3e8de9a34de48c49c29d398bf4e8

Modified Files
--------------
src/bin/pg_upgrade/.gitignore | 4 ++++
src/bin/pg_upgrade/Makefile   | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1o1Mic-0008RL-Bz@gemulon.postgresql.org>
Permalink:  ../E1o1Mic-0008RL-Bz@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1o1Mic-0008RL-Bz@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Re-add locally-generated files in pg_upgrade's .gitignore and Ma
  In-Reply-To: <E1o1Mic-0008RL-Bz@gemulon.postgresql.org>
  References: <E1o1Mic-0008RL-Bz@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox