public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Todd Cook <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Noah Misch <[email protected]>
Subject: Re: TEMP_CONFIG vs test_aio
Date: Tue, 1 Apr 2025 16:17:05 -0400
Message-ID: <4fi62oxjougycbzfuynokg2gajxx3j4ue6velmbzgtski5jlpz@72ri5hvlntac> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<zh5u22wbpcyfw2ddl3lsvmsxf4yvsrvgxqwwmfjddc4c2khsgp@gfysyjsaelr5>
	<[email protected]>

Hi,

On 2025-04-01 20:12:29 +0000, Todd Cook wrote:
> On 4/1/25, 3:42 PM, "Andres Freund" <[email protected] <mailto:[email protected]>> wrote:
> > I just committed the tests for AIO, and unfortunately they (so far) fail on
> > one buildfarm animal:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&dt=2025-04-01%2018%3A55%3A01 <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&amp;dt=2025-04-01%2018%3A55%3A...;
> >
> > The reason for the failure is simple, the buildfarm animal specifies
> > io_method=io_uring (thanks to "cookt" for setting that up so quickly, whoever
> > you are :)) and the test is assuming that the -c io_method=... it passes to
> > initdb is actually going to be used, but it's overwritten by the TEMP_CONFIG.
>
> You're welcome!
>
> Is there an alternate way I could use to configure the io_method on bumblebee?

You could use PG_TEST_INITDB_EXTRA_OPTS, but I think you did it the right
way.

For one using PG_TEST_INITDB_EXTRA_OPTS would probably require changing the
buildfarm code, because the buildfarm code filters out environment variables
that aren't on an allowlist (I really dislike that).

IOW, I think we should figure out a way to deal with TEMP_CONFIG containing
io_method=io_uring, I just don't really know how yet.

Greetings,

Andres

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: TEMP_CONFIG vs test_aio
  In-Reply-To: <4fi62oxjougycbzfuynokg2gajxx3j4ue6velmbzgtski5jlpz@72ri5hvlntac>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox