public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Andres Freund <[email protected]>
Cc: Todd Cook <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Noah Misch <[email protected]>
Subject: Re: TEMP_CONFIG vs test_aio
Date: Wed, 2 Apr 2025 08:34:11 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <lon4dng6lffn4hamo3n654lo5w2zjadap3e437cdfr5lxdklll@vemlvmfgnbox>
References: <[email protected]>
	<zh5u22wbpcyfw2ddl3lsvmsxf4yvsrvgxqwwmfjddc4c2khsgp@gfysyjsaelr5>
	<[email protected]>
	<4fi62oxjougycbzfuynokg2gajxx3j4ue6velmbzgtski5jlpz@72ri5hvlntac>
	<[email protected]>
	<lon4dng6lffn4hamo3n654lo5w2zjadap3e437cdfr5lxdklll@vemlvmfgnbox>


On 2025-04-01 Tu 5:34 PM, Andres Freund wrote:
> Hi,
>
> On 2025-04-01 17:08:49 -0400, Andrew Dunstan wrote:
>> On 2025-04-01 Tu 4:17 PM, Andres Freund wrote:
>>> For one using PG_TEST_INITDB_EXTRA_OPTS would probably require changing the
>>> buildfarm code, because the buildfarm code filters out environment variables
>>> that aren't on an allowlist (I really dislike that).
>>
>> Uh, not quite. Anything in the config's build_env is not filtered out. That
>> change was made a year ago.
> Huh. Just recently I tried to configure PG_TEST_TIMEOUT_DEFAULT in build_env
> and did not take effect until I explicitly added it to the @safe_set.
>


Correction: the code changed was a year ago, bit it was in release 18, 
which was in November. If it didn't work after that I want to know.


This is the commit: 
https://github.com/PGBuildFarm/client-code/commit/e2dd43915b4aa97447a5e8118f733b444896db81


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

view thread (8+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: TEMP_CONFIG vs test_aio
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox