From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add transforms feature
Date: Tue, 28 Apr 2015 11:51:13 -0400
Message-ID: <553FAC70.2070309@dunslane.net> (raw)
In-Reply-To: <CAB7nPqRWEgqGQqTc-0bdRTBGbbnPyDEStnOEJw6ffFw=504nhQ@mail.gmail.com>
References: <E1YmNw0-0002Kb-3Q@gemulon.postgresql.org>
<18844.1430066190@sss.pgh.pa.us>
<CAB7nPqRE6PpdMbwvytXCcKsnwg-TKM=0sfsH=DoCRKEvJVusKw@mail.gmail.com>
<553E29B5.9000102@gmx.net>
<553ECC34.2090104@dunslane.net>
<553EDA8A.9090806@dunslane.net>
<CAB7nPqT1k22QhvbX7npTY0BqLgGTPQU1eN8u78LBAuy57Y8jRg@mail.gmail.com>
<CAB7nPqRWEgqGQqTc-0bdRTBGbbnPyDEStnOEJw6ffFw=504nhQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
On 04/28/2015 09:04 AM, Michael Paquier wrote:
> On Tue, Apr 28, 2015 at 10:01 AM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote:
>>> w.r.t MSVC builds, it looks like we need entries in $contrib_extraincludes
>>> in src/tools/msvc/Mkvcbuild.pm at the very least.
>> If our goal is to put back to green the Windows nodes as quick as
>> possible, we could bypass their build this way , and we'll
>> additionally need to update the install script and
>> vcregress.pl/contribcheck to bypass those modules accordingly. Now I
>> don't think that we should make the things produced inconsistent.
> OK, attached are two patches to put back the buildfarm nodes using MSVC to green
> - 0001 adds support for build and installation of the new transform
> modules: hstore_plperl, hstore_plpython and ltree_plpython. Note that
> this patch is enough to put back the buildfarm to a green state for
> MSVC, but it disables the regression tests for those modules,
> something addressed in the next patch...
> - 0002 adds support for regression tests for the new modules. The
> thing is that we need to check the major version version of Python
> available in configuration and choose what are the extensions to
> preload before the tests run. It is a little bit hacky... But it has
> the merit to work, and I am not sure we could have a cleaner solution
> by looking at the Makefiles of the transform modules that use
> currently conditions based on $(python_majorversion).
> Regards,
I have pushed the first of these with some tweaks.
I'm looking at the second.
cheers
andrew
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, michael.paquier@gmail.com, peter_e@gmx.net, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Add transforms feature
In-Reply-To: <553FAC70.2070309@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox