From: Nasby, Jim <nasbyj@amazon.com>
To: Andres Freund <andres@anarazel.de>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru
Date: Mon, 24 Sep 2018 19:53:48 +0000
Message-ID: <57414BDC-71F7-4CDD-8A59-3F277C3207ED@amazon.com> (raw)
In-Reply-To: <20180924182934.rpl3lkoisy5o2tx4@alap3.anarazel.de>
References: <E1g0aGi-0000uN-Sq@gemulon.postgresql.org>
<20180914153554.562muwr3uwujno75@alvherre.pgsql>
<CA+Tgmoa7JJG0g2rCR=m8wXzExZDBpHPo04a5FyV-EotknVDONg@mail.gmail.com>
<7924791537551496@myt5-c56023d17c6b.qloud-c.yandex.net>
<20180921174347.wvszsn7uk56zvz7o@alap3.anarazel.de>
<0A11E30F-DDDE-422F-B22A-3F6E3AA7A0A2@amazon.com>
<20180924182934.rpl3lkoisy5o2tx4@alap3.anarazel.de>
> On Sep 24, 2018, at 1:29 PM, Andres Freund <andres@anarazel.de> wrote:
>
> I'm very doubtful this is an improvement. Especially with the upcoming
> pluggable storage work making vacuumlazy.c heap specific, while vacuum.c
> stays generic. The concept of something like
> PROC_VACUUM_FOR_WRAPAROUND, should imo not be pushed down that much
> (even if criteria for it might).
That’s already a problem since vacuum logging is spread all over while autovac logging is not. Perhaps there needs to be some sort of vacuum_log() function that immediately provides output for manual vacuums, but aggregates output for autovac. AFAIK that’s the only real reason for autovac logging being a special case today.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nasbyj@amazon.com, andres@anarazel.de, sk@zsrv.org, robertmhaas@gmail.com, alvherre@2ndquadrant.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru
In-Reply-To: <57414BDC-71F7-4CDD-8A59-3F277C3207ED@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox