pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org, John Naylor <john.naylor@enterprisedb.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: John Naylor <john.naylor@postgresql.org>
Subject: Re: pgsql: Build all Flex files standalone
Date: Mon, 05 Sep 2022 20:54:11 -0700
Message-ID: <5977D592-1CA0-4B40-8251-D008C3EF36F0@anarazel.de> (raw)
In-Reply-To: <CAFBsxsFQXQuK3uhFNBxbTSTM2s7jgFKQyvap1TdQ_d85+puuCg@mail.gmail.com>
References: <E1oUhv4-001MaA-Et@gemulon.postgresql.org>
	<CAFBsxsE3Cx_n1TS7cEtCX1fOpuZYEDqzHFZQUZvSHk7vfDFNAA@mail.gmail.com>
	<e3f4a3d0-dfcc-41cc-1ed2-acc15700ddef@dunslane.net>
	<CAFBsxsFQXQuK3uhFNBxbTSTM2s7jgFKQyvap1TdQ_d85+puuCg@mail.gmail.com>

Hi,



On September 5, 2022 8:33:37 PM PDT, John Naylor <john.naylor@enterprisedb.com> wrote:
>On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>>
>>
>> On 2022-09-04 Su 02:19, John Naylor wrote:
>> > Crake fails with
>> >
>> > headerscheck:
>> > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
>> > Sep 04 01:56:01
>> > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
>> > fatal error: jsonpath_gram.h: No such file or directory
>> > Sep 04 01:56:01    26 | #include "jsonpath_gram.h"
>> > Sep 04 01:56:01       |          ^~~~~~~~~~~~~~~~~
>> > Sep 04 01:56:01 compilation terminated.
>> > Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1
>> > cpluspluscheck:
>> > Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3:
>> > Sep 04 01:57:19
>> > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
>> > fatal error: jsonpath_gram.h: No such file or directory
>> > Sep 04 01:57:19    26 | #include "jsonpath_gram.h"
>> > Sep 04 01:57:19       |          ^~~~~~~~~~~~~~~~~
>> >
>> > I don't get the same in an already-built tree. I also don't see an
>> > exception for gramparse.h, which I imagine would have the same issue?
>>
>>
>>
>> Probably happens because crake does vpath builds. I think you're going
>> to have to set up EXTRAINCLUDES for it - see near the bottom of the
>> headerscheck script. Possibly something like
>>
>>
>>     src/backend/utils/adt/*)
>>
>>     EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;
>
>I just tried a vpath build and the failing check doesn't reproduce for
>me there. Any ideas?

Presumably it only happens if you previously triggered the parsers to be generated.

Andres

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.





view thread (14+ messages)  latest in thread

Message-ID: <5977D592-1CA0-4B40-8251-D008C3EF36F0@anarazel.de>
Permalink:  ../5977D592-1CA0-4B40-8251-D008C3EF36F0@anarazel.de/
Also on:    postgresql.org/message-id/5977D592-1CA0-4B40-8251-D008C3EF36F0@anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, john.naylor@enterprisedb.com, andrew@dunslane.net, john.naylor@postgresql.org
  Subject: Re: pgsql: Build all Flex files standalone
  In-Reply-To: <5977D592-1CA0-4B40-8251-D008C3EF36F0@anarazel.de>
  References: <E1oUhv4-001MaA-Et@gemulon.postgresql.org> <CAFBsxsE3Cx_n1TS7cEtCX1fOpuZYEDqzHFZQUZvSHk7vfDFNAA@mail.gmail.com> <e3f4a3d0-dfcc-41cc-1ed2-acc15700ddef@dunslane.net> <CAFBsxsFQXQuK3uhFNBxbTSTM2s7jgFKQyvap1TdQ_d85+puuCg@mail.gmail.com> <5977D592-1CA0-4B40-8251-D008C3EF36F0@anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox