pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Daniel Gustafsson <daniel@yesql.se>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Clean up role created in new subscription test.
Date: Wed, 8 Nov 2023 13:15:00 +0100
Message-ID: <5A9E99CC-4F05-47AC-8369-AD2E41A1D6E6@yesql.se> (raw)
In-Reply-To: <41dba437-5622-4ae0-a6bb-726da8771584@eisentraut.org>
References: <E1phvk7-000VAH-7k@gemulon.postgresql.org>
	<CA+TgmoZ+K2OU0Ojs8_4SgqPWJJq7e0XiLd-uJGZ11R_WKF1URQ@mail.gmail.com>
	<267900.1680201870@sss.pgh.pa.us>
	<99112997-6732-42C7-989B-06406C911FE2@yesql.se>
	<284965.1680208176@sss.pgh.pa.us>
	<0134C9EC-5F6B-4EAC-B2D5-BB4249BEBD4D@yesql.se>
	<3C83CEE2-0758-400C-979C-FD9E828C4709@yesql.se>
	<4447BBC5-26DA-4BDB-838B-50819E8E6EA7@yesql.se>
	<41dba437-5622-4ae0-a6bb-726da8771584@eisentraut.org>

> On 8 Nov 2023, at 08:55, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
> On 06.07.23 00:00, Daniel Gustafsson wrote:
>>> On 16 May 2023, at 11:17, Daniel Gustafsson <daniel@yesql.se> wrote:
>>> Parked in the July CF for now.
>> Rebased to fix a trivial conflict highlighted by the CFBot.
> 
> I think the problem with this approach is that one would need to reapply it to each regression test suite separately.  For example, there are several tests under contrib/ that create roles.  These would not be covered by this automatically.
> 
> I think the earlier idea of just counting roles, tablespaces, etc. before and after would be sufficient.

It's been a while but if memory serves me right, one of the reasons for this
approach was that pg_regress didn't use libpq so running queries and storing
results for comparisons other than diffing .out files was painful at best.

Since 66d6086cbc pg_regress does have a dependency on libpq so we can now
perform that bookkeeping a bit easier.  I still find it more elegant to at
least compare the contents and not just the count, but I can take a stab at a
revised patch since this approach doesn't seem to appeal to the thread.

--
Daniel Gustafsson






view thread (28+ messages)  latest in thread

Message-ID: <5A9E99CC-4F05-47AC-8369-AD2E41A1D6E6@yesql.se>
Permalink:  ../5A9E99CC-4F05-47AC-8369-AD2E41A1D6E6@yesql.se/
Also on:    postgresql.org/message-id/5A9E99CC-4F05-47AC-8369-AD2E41A1D6E6@yesql.se

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: daniel@yesql.se, peter@eisentraut.org, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Clean up role created in new subscription test.
  In-Reply-To: <5A9E99CC-4F05-47AC-8369-AD2E41A1D6E6@yesql.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox