From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Allow insert and update tuple routing and COPY for foreign table
Date: Fri, 26 Apr 2019 13:58:15 +0900
Message-ID: <5CC28FE7.90607@lab.ntt.co.jp> (raw)
In-Reply-To: <1cc7b8be-d201-8bad-5d98-350faccf095c@lab.ntt.co.jp>
References: <E1f4aif-0004qo-A6@gemulon.postgresql.org>
<ed0b7471dce91169d871347cf003d8094ab96895.camel@cybertec.at>
<5CBDB770.2060602@lab.ntt.co.jp>
<b459d1b1b4eb8c0d538a2c5b70e131af3c391954.camel@cybertec.at>
<5CC04E72.90405@lab.ntt.co.jp>
<bf36a0288e8f31b4f2f40952e225bf892dc1ffc5.camel@cybertec.at>
<5CC1B358.5090205@lab.ntt.co.jp>
<1cc7b8be-d201-8bad-5d98-350faccf095c@lab.ntt.co.jp>
Amit-san,
(2019/04/26 13:20), Amit Langote wrote:
> On 2019/04/25 22:17, Etsuro Fujita wrote:
>> (2019/04/24 22:04), Laurenz Albe wrote:
>>> Before PostgreSQL v11, a foreign data wrapper could be certain that
>>> BeginForeignModify is always called before ExecForeignInsert.
>>> This is no longer true.
>>
>> OK, how about something like the attached? I reworded this a bit, though.
>
> Thanks for the patch.
>
> + Note that this function is also called when inserting routed tuples into
> + a foreign-table partition or executing<command>COPY FROM</command> on
> + a foreign table, in which case it is called in a different way than it
> + is in the<command>INSERT</command> case.
>
> Maybe minor, but should the last part of this sentence read as:
>
> ...in which case it is called in a different way than it is in the case
> <command>INSERT</command> is operating directly on the foreign table.
>
> ?
Yeah, but I think it would be OK to just say "the INSERT case" because
this note is added to the docs for ExecForeignInsert(), which allows the
FDW to directly insert into foreign tables as you know, so users will
read "the INSERT case" as "the case <command>INSERT</command> is
operating directly on the foreign table".
Thanks for the comment!
Best regards,
Etsuro Fujita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujita.etsuro@lab.ntt.co.jp, Langote_Amit_f8@lab.ntt.co.jp, laurenz.albe@cybertec.at, rhaas@postgresql.org, pgsql-committers@lists.postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Allow insert and update tuple routing and COPY for foreign table
In-Reply-To: <5CC28FE7.90607@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox