pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Justin Pryzby <pryzby@telsasoft.com>
To: Beena Emerson <memissemerson@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE
Date: Tue, 6 Sep 2022 07:44:13 +0200
Message-ID: <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com> (raw)
In-Reply-To: <20220720145220.GJ12702@telsasoft.com>
References: <20220720145220.GJ12702@telsasoft.com>

On 20.07.22 16:52, Justin Pryzby wrote:
> +/* GUC_UNIT_* are not flags - they're tested for equality */

Well, there is GUC_UNIT_MEMORY, etc. so there is an additional 
constraint beyond just "pick any number".  I'm not sure that "flag" and 
"tested for equality" are really antonyms anyway.

I think renumbering this makes sense.  We could just leave the comment 
as is if we don't come up with a better wording.

>   #define GUC_UNIT_KB				0x1000	/* value is in kilobytes */
>   #define GUC_UNIT_BLOCKS			0x2000	/* value is in blocks */
>   #define GUC_UNIT_XBLOCKS		0x3000	/* value is in xlog blocks */
>   #define GUC_UNIT_MB				0x4000	/* value is in megabytes */
> -#define GUC_UNIT_BYTE			0x8000	/* value is in bytes */
> +#define GUC_UNIT_BYTE			0x5000	/* value is in bytes */
>   #define GUC_UNIT_MEMORY			0xF000	/* mask for size-related units */
>   
>   #define GUC_UNIT_MS			   0x10000	/* value is in milliseconds */
> 
> 






view thread (6+ messages)  latest in thread

Message-ID: <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com>
Permalink:  ../5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com/
Also on:    postgresql.org/message-id/5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, pryzby@telsasoft.com, memissemerson@gmail.com, andres@anarazel.de, pgsql-hackers@postgresql.org
  Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE
  In-Reply-To: <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com>
  References: <20220720145220.GJ12702@telsasoft.com> <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox