pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Erik Rijkers <er@xs4all.nl>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
To: Alexander Korotkov <akorotkov@postgresql.org>
Subject: typo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins
Date: Thu, 20 Aug 2026 02:31:20 +0200
Message-ID: <5af2dbe4-1230-cf8b-0a62-19e0517490e2@xs4all.nl> (raw)
In-Reply-To: <E1wwdrI-00000001CbA-30di@gemulon.postgresql.org>
References: <E1wwdrI-00000001CbA-30di@gemulon.postgresql.org>

Op 8/19/26 om 12:49 schreef Alexander Korotkov:
> postgres_fdw: push down FUNCTION RTE into foreign joins
> 
> A foreign join planning hook now considers a (foreign-table x function-RTE)
> INNER join as a push-down candidate when the function > 
...
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/0ee83dd4a9940883b5241fc9c80fd27f63f2e47f
> 
> Modified Files
> --------------
> contrib/postgres_fdw/deparse.c                 | 157 +++++-
> contrib/postgres_fdw/expected/postgres_fdw.out | 627 ++++++++++++++++++++++++
> contrib/postgres_fdw/postgres_fdw.c            | 642 +++++++++++++++++++++++--
> contrib/postgres_fdw/postgres_fdw.h            |  12 +
> contrib/postgres_fdw/sql/postgres_fdw.sql      | 274 +++++++++++
> doc/src/sgml/postgres-fdw.sgml                 |  18 +
> src/backend/optimizer/util/relnode.c           |  25 +
> 7 files changed, 1698 insertions(+), 57 deletions(-)

Hi,

in: doc/src/sgml/postgres-fdw.sgml, I believe this sentence:

  "and none of the following disqualifying conditions applies:"

should be:

  "and none of the following disqualifying conditions apply:"

Please, can a native English speaker confirm?

Thanks,

Erik






view thread (2+ messages)  latest in thread

Message-ID: <5af2dbe4-1230-cf8b-0a62-19e0517490e2@xs4all.nl>
Permalink:  ../5af2dbe4-1230-cf8b-0a62-19e0517490e2@xs4all.nl/
Also on:    postgresql.org/message-id/5af2dbe4-1230-cf8b-0a62-19e0517490e2@xs4all.nl

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: er@xs4all.nl, pgsql-hackers@lists.postgresql.org, akorotkov@postgresql.org
  Subject: Re: typo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins
  In-Reply-To: <5af2dbe4-1230-cf8b-0a62-19e0517490e2@xs4all.nl>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox