pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedtypo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins
2+ messages / 2 participants
[nested] [flat]
* typo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins
@ 2026-08-20 00:31 Erik Rijkers <er@xs4all.nl>
2026-08-20 12:52 ` Re: typo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins Robert Treat <rob@xzilla.net>
0 siblings, 1 reply; 2+ messages in thread
From: Erik Rijkers @ 2026-08-20 00:31 UTC (permalink / raw)
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>; Alexander Korotkov <akorotkov@postgresql.org>
Op 8/19/26 om 12:49 schreef Alexander Korotkov:
> postgres_fdw: push down FUNCTION RTE into foreign joins
>
> A foreign join planning hook now considers a (foreign-table x function-RTE)
> INNER join as a push-down candidate when the function >
...
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/0ee83dd4a9940883b5241fc9c80fd27f63f2e47f
>
> Modified Files
> --------------
> contrib/postgres_fdw/deparse.c | 157 +++++-
> contrib/postgres_fdw/expected/postgres_fdw.out | 627 ++++++++++++++++++++++++
> contrib/postgres_fdw/postgres_fdw.c | 642 +++++++++++++++++++++++--
> contrib/postgres_fdw/postgres_fdw.h | 12 +
> contrib/postgres_fdw/sql/postgres_fdw.sql | 274 +++++++++++
> doc/src/sgml/postgres-fdw.sgml | 18 +
> src/backend/optimizer/util/relnode.c | 25 +
> 7 files changed, 1698 insertions(+), 57 deletions(-)
Hi,
in: doc/src/sgml/postgres-fdw.sgml, I believe this sentence:
"and none of the following disqualifying conditions applies:"
should be:
"and none of the following disqualifying conditions apply:"
Please, can a native English speaker confirm?
Thanks,
Erik
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: typo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins
2026-08-20 00:31 typo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins Erik Rijkers <er@xs4all.nl>
@ 2026-08-20 12:52 ` Robert Treat <rob@xzilla.net>
0 siblings, 0 replies; 2+ messages in thread
From: Robert Treat @ 2026-08-20 12:52 UTC (permalink / raw)
To: Erik Rijkers <er@xs4all.nl>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>; Alexander Korotkov <akorotkov@postgresql.org>
On Wed, Aug 19, 2026 at 8:32 PM Erik Rijkers <er@xs4all.nl> wrote:
>
> Op 8/19/26 om 12:49 schreef Alexander Korotkov:
> > postgres_fdw: push down FUNCTION RTE into foreign joins
> >
> > A foreign join planning hook now considers a (foreign-table x function-RTE)
> > INNER join as a push-down candidate when the function >
> ...
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > https://git.postgresql.org/pg/commitdiff/0ee83dd4a9940883b5241fc9c80fd27f63f2e47f
> >
> > Modified Files
> > --------------
> > contrib/postgres_fdw/deparse.c | 157 +++++-
> > contrib/postgres_fdw/expected/postgres_fdw.out | 627 ++++++++++++++++++++++++
> > contrib/postgres_fdw/postgres_fdw.c | 642 +++++++++++++++++++++++--
> > contrib/postgres_fdw/postgres_fdw.h | 12 +
> > contrib/postgres_fdw/sql/postgres_fdw.sql | 274 +++++++++++
> > doc/src/sgml/postgres-fdw.sgml | 18 +
> > src/backend/optimizer/util/relnode.c | 25 +
> > 7 files changed, 1698 insertions(+), 57 deletions(-)
>
> Hi,
>
> in: doc/src/sgml/postgres-fdw.sgml, I believe this sentence:
>
> "and none of the following disqualifying conditions applies:"
>
> should be:
>
> "and none of the following disqualifying conditions apply:"
>
> Please, can a native English speaker confirm?
>
+1. to the above. FWIW, the rest of the original patch seems fine.
Robert Treat
https://xzilla.net
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-20 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-08-20 00:31 typo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins Erik Rijkers <er@xs4all.nl>
2026-08-20 12:52 ` Robert Treat <rob@xzilla.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox