From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix compiler warning
Date: Thu, 5 Sep 2019 16:05:40 +0200
Message-ID: <5c927b9b-0000-ce62-6a18-1e0ed825c5c4@2ndquadrant.com> (raw)
In-Reply-To: <20190902080326.GB25912@paquier.xyz>
References: <E1i4XIR-0006li-3c@gemulon.postgresql.org>
<20190902010409.GC1841@paquier.xyz>
<e4e060b8-d4d8-28e7-4221-3967b8adb830@2ndquadrant.com>
<20190902080326.GB25912@paquier.xyz>
On 2019-09-02 10:03, Michael Paquier wrote:
> On Mon, Sep 02, 2019 at 07:54:16AM +0200, Peter Eisentraut wrote:
>> Is this code new in PG12? Doesn't look like it to me.
>
> Well, 12 has not been released yet, which is the point I am trying to
> make. The code was introduced in 10, and as the fix is trivial it
> seems to me that it could be back-patched. For example even recently
> you back-patched f02bd63 in the same category. If you don't think
> that's worth it, that's fine for me as well.
That patch made sure the whole tree compiles without warning.
The tree currently does not compile without warnings on Windows (for
me), so it doesn't seem worth fixing warnings piece by piece in the
backbranches.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix compiler warning
In-Reply-To: <5c927b9b-0000-ce62-6a18-1e0ed825c5c4@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox