public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Andres Freund <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: aio: Infrastructure for io_method=worker
Date: Tue, 18 Mar 2025 21:24:16 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <27fwadt6whe5ufqyrgbrnu3ppfiocaljtt3fufedn6sclvjqll@kotindcvgtoy>
References: <[email protected]>
	<[email protected]>
	<27fwadt6whe5ufqyrgbrnu3ppfiocaljtt3fufedn6sclvjqll@kotindcvgtoy>

Andres Freund <[email protected]> writes:
> On 2025-03-18 18:53:48 -0400, Tom Lane wrote:
>> I wonder though if we ought to revert 38da05346 and/or 6d0154196 in view of
>> that.

> 38da05346 doesn't seem to have much value if it doesn't help us run the tests
> by default - but it also doesn't really hurt. So, shrug, I guess.

> 6d0154196 - a higher autovacuum_worker_slots increases resource usage more
> than IO workers do, because autovac workers are included in computations like
> lock space. But 16 isn't that much either way...

IMV the argument for reverting either would basically be simplicity.
It's not even so much the code, as the comments defending these odd
looking choices.  Future hackers will read those and wonder if the
arguments still apply --- and the answer will be "no".

38da05346 was back-patched into 17, and I'd leave it as-is there,
since it was holding the line on "can start with 60 semaphores"
for that branch.  But once we've lost that battle, it's hard to
see what it's doing for us.

			regards, tom lane

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgsql: aio: Infrastructure for io_method=worker
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox