public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andres Freund <[email protected]>
To: [email protected]
Subject: pgsql: aio: Infrastructure for io_method=worker
Date: Tue, 18 Mar 2025 16:01:43 +0000
Message-ID: <[email protected]> (raw)

aio: Infrastructure for io_method=worker

This commit contains the basic, system-wide, infrastructure for
io_method=worker. It does not yet actually execute IO, this commit just
provides the infrastructure for running IO workers, kept separate for easier
review.

The number of IO workers can be adjusted with a PGC_SIGHUP GUC. Eventually
we'd like to make the number of workers dynamically scale up/down based on the
current "IO load".

To allow the number of IO workers to be increased without a restart, we need
to reserve PGPROC entries for the workers unconditionally. This has been
judged to be worth the cost. If it turns out to be problematic, we can
introduce a PGC_POSTMASTER GUC to control the maximum number.

As io workers might be needed during shutdown, e.g. for AIO during the
shutdown checkpoint, a new PMState phase is added. IO workers are shut down
after the shutdown checkpoint has been performed and walsender/archiver have
shut down, but before the checkpointer itself shuts down. See also
87a6690cc69.

Updates PGSTAT_FILE_FORMAT_ID due to the addition of a new BackendType.

Reviewed-by: Noah Misch <[email protected]>
Co-authored-by: Thomas Munro <[email protected]>
Co-authored-by: Andres Freund <[email protected]>
Discussion: https://postgr.es/m/uvrtrknj4kdytuboidbhwclo4gxhswwcpgadptsjvjqcluzmah%40brqs62irg4dt
Discussion: https://postgr.es/m/[email protected]
Discussion: https://postgr.es/m/stj36ea6yyhoxtqkhpieia2z4krnam7qyetc57rfezgk4zgapf@gcnactj4z56m

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55b454d0e14084c841a034073abbf1a0ea937a45

Modified Files
--------------
doc/src/sgml/config.sgml                        |  19 +++
src/backend/postmaster/launch_backend.c         |   2 +
src/backend/postmaster/pmchild.c                |   1 +
src/backend/postmaster/postmaster.c             | 174 ++++++++++++++++++++++--
src/backend/storage/aio/Makefile                |   1 +
src/backend/storage/aio/meson.build             |   1 +
src/backend/storage/aio/method_worker.c         |  88 ++++++++++++
src/backend/tcop/postgres.c                     |   7 +
src/backend/utils/activity/pgstat_backend.c     |   1 +
src/backend/utils/activity/pgstat_io.c          |   1 +
src/backend/utils/activity/wait_event_names.txt |   1 +
src/backend/utils/init/miscinit.c               |   3 +
src/backend/utils/misc/guc_tables.c             |  13 ++
src/backend/utils/misc/postgresql.conf.sample   |   1 +
src/include/miscadmin.h                         |   2 +
src/include/pgstat.h                            |   2 +-
src/include/storage/aio_subsys.h                |   4 +
src/include/storage/io_worker.h                 |  22 +++
src/include/storage/proc.h                      |   4 +-
src/test/regress/expected/stats.out             |  10 +-
20 files changed, 342 insertions(+), 15 deletions(-)



view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: aio: Infrastructure for io_method=worker
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox