From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Avoid creation of the free space map for small heap relations, t
Date: Mon, 25 Feb 2019 12:44:28 -0500
Message-ID: <649.1551116668@sss.pgh.pa.us> (raw)
In-Reply-To: <32368.1551114120@sss.pgh.pa.us>
References: <E1gqTuL-0004Wj-U7@gemulon.postgresql.org>
<32368.1551114120@sss.pgh.pa.us>
I wrote:
> Amit Kapila <akapila@postgresql.org> writes:
>> Avoid creation of the free space map for small heap relations, take 2.
> I think this patch still has some issues.
Just out of curiosity ... how can it possibly be even a little bit sane
that fsm_local_map is a single static data structure, without even any
indication of which table it is for?
If, somehow, there's a rational argument for that design, why is it
not explained in freespace.c? The most charitable interpretation of
what I see there is that it's fatally undercommented.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, akapila@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Avoid creation of the free space map for small heap relations, t
In-Reply-To: <649.1551116668@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox