From: Peter Eisentraut <peter@eisentraut.org>
To: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Restrict accesses to non-system views and foreign tables during
Date: Mon, 26 Aug 2024 16:14:09 +0200
Message-ID: <6a96f1af-22b4-4a80-8161-1f26606b9ee2@eisentraut.org> (raw)
In-Reply-To: <E1saxQr-002nFK-SJ@gemulon.postgresql.org>
References: <E1saxQr-002nFK-SJ@gemulon.postgresql.org>
On 05.08.24 15:07, Masahiko Sawada wrote:
> To address this, pg_dump now utilizes the newly introduced
> restrict_nonsystem_relation_kind GUC parameter to restrict the
> accesses to non-system views and foreign tables during the dump
> process. This new GUC parameter is added to back branches too, but
> these changes do not require cluster recreation.
This documentation of this new parameter is a bit hard to understand.
The description in guc_tables.c is
"Sets relation kinds of non-system relation to restrict use"
which is hard to understand even knowing what this setting is supposed
to do.
In config.sgml it says
+ This variable specifies relation kind to which access is restricted.
+ It contains a comma-separated list of relation kind. Currently, the
+ supported relation kinds are <literal>view</literal> and
+ <literal>foreign-table</literal>.
This does not mention "system" or "non-system" at all.
Also, the phrase "to which access is restricted" can be interpreted in
two opposite ways:
- access to those relations is prohibited
- access is limited to those relations
Also nothing anywhere clarifies what "restricted" means here, and the
term introduces unnecessary ambiguity.
Can we come up with some more precise and easier-to-understand language?
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, msawada@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Restrict accesses to non-system views and foreign tables during
In-Reply-To: <6a96f1af-22b4-4a80-8161-1f26606b9ee2@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox