From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: [COMMITTERS] pgsql: Fix bool/int type confusion
Date: Thu, 21 Sep 2017 14:23:27 -0400
Message-ID: <6f69d4e1-647e-4f05-28a8-117388d3bfe9@2ndquadrant.com> (raw)
In-Reply-To: <20053.1506008800@sss.pgh.pa.us>
References: <E1dsWhf-0000pT-F9@gemulon.postgresql.org>
<20053.1506008800@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 9/21/17 11:46, Tom Lane wrote:
> So the code in their git repo still has the variable as bool, but
> there's no ++ operator on it anymore.
>
> This also means that the portability problem is purely hypothetical;
> given valid tz reference data the code wouldn't ever try to increment
> "hit" to 2 anyway. It's even more hypothetical for us, because we don't
> use leap-second-aware zones.
It's not so much that there is an actual portability problem. The
problem is that the compiler issues a warning for this with stdbool.
> Therefore, what I would like to do is revert this commit (0ec2e908b),
> and then either leave the problem to be fixed by our next regular sync
> with a released tzcode version, or else force a sync with their git tip
> to absorb their fix now. In either case we should keep all our live
> branches in sync. I'm willing to do the code-sync work either way.
That makes sense. There is no urgency on the stdbool patch set, so
waiting for this to be resolved properly around November seems reasonable.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@postgreSQL.org
Subject: Re: [COMMITTERS] pgsql: Fix bool/int type confusion
In-Reply-To: <6f69d4e1-647e-4f05-28a8-117388d3bfe9@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox