public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: Jeff Davis <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
Date: Wed, 2 Apr 2025 08:25:24 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Mar 31, 2025, at 3:12, Jeff Davis <[email protected]> wrote:
> Why pg_strdup() the "NULL" at all in that case? Usually I see that done
> so that there doesn't need to be a conditional when freeing, but here
> there's a conditional anyway.
> 
> Perhaps something like the attached?

This would work for me as well. I’m ok to take care of it at the beginning of next week, based on your suggestion.
--
Michael

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox