pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-committers@postgresql.org, PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
Date: Mon, 07 Aug 2017 15:21:34 -0400
Message-ID: <7295.1502133694@sss.pgh.pa.us> (raw)
In-Reply-To: <d6ca14d4-a475-6496-48b6-d9f58b29a875@2ndQuadrant.com>
References: <E1dcE5n-0005Sk-UE@gemulon.postgresql.org>
	<d6ca14d4-a475-6496-48b6-d9f58b29a875@2ndQuadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 07/31/2017 01:02 PM, Tom Lane wrote:
>> Record full paths of programs sought by "configure".

> The problem with this commit, as jacana is demonstrating, is that on
> Msys it finds the wrong prove. configure needs to run against the perl
> we build against, i.e. a native Windows perl, but prove needs to run
> with the perl from the MSys DTK that understands MSys virtualized
> paths. I have a hack that will allow the buildfarm to overcome the
> difficulty, (essentially it passes 'PROVE=prove' to make) but that's
> fairly ugly and certainly non-intuitive for someone running an MSys
> build and TAP tests without the buildfarm client.

I'm confused.  AFAIK, that commit did not change which "prove" would
be used --- at least not unless you change PATH between configure and
make.  It only changed how specifically that program would be named in
Makefile.global.  Please clarify how that broke anything.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (10+ messages)  latest in thread

Message-ID: <7295.1502133694@sss.pgh.pa.us>
Permalink:  ../7295.1502133694@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/7295.1502133694@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, pgsql-hackers@postgresql.org
  Subject: Re: [COMMITTERS] pgsql: Record full paths of programs sought by "configure".
  In-Reply-To: <7295.1502133694@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox