pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
4+ messages / 4 participants
[nested] [flat]
Commits from this thread:
2025-06-11 e1458f2f1b Revert a few small patches that were intended for version 19.
* pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
@ 2025-06-10 18:24 Jeff Davis <jdavis@postgresql.org>
2025-06-10 19:49 ` Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <pgsql@j-davis.com>
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Davis @ 2025-06-10 18:24 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
Avoid dependence on setlocale(). No behavior change.
Discussion: https://postgr.es/m/9875f7f9-50f1-4b5d-86fc-ee8b03e8c162@eisentraut.org
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8898082a5d3e94eef073f0e08124137e096e78ef
Modified Files
--------------
src/backend/utils/adt/inet_net_pton.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
2025-06-10 18:24 pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <jdavis@postgresql.org>
@ 2025-06-10 19:49 ` Jeff Davis <pgsql@j-davis.com>
2025-06-10 20:31 ` Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Davis @ 2025-06-10 19:49 UTC (permalink / raw)
To: Jeff Davis <jdavis@postgresql.org>; pgsql-committers@lists.postgresql.org
On Tue, 2025-06-10 at 18:24 +0000, Jeff Davis wrote:
> inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
These 4 small patches were somewhat of a "false start" on 19 -- sorry
about that. Not sure if it's worth it to revert them and reapply in a
couple weeks, as they look pretty harmless.
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
2025-06-10 18:24 pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <jdavis@postgresql.org>
2025-06-10 19:49 ` Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <pgsql@j-davis.com>
@ 2025-06-10 20:31 ` Tom Lane <tgl@sss.pgh.pa.us>
2025-06-10 20:56 ` Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Heikki Linnakangas <hlinnaka@iki.fi>
0 siblings, 1 reply; 4+ messages in thread
From: Tom Lane @ 2025-06-10 20:31 UTC (permalink / raw)
To: Jeff Davis <pgsql@j-davis.com>; +Cc: Jeff Davis <jdavis@postgresql.org>; pgsql-committers@lists.postgresql.org
Jeff Davis <pgsql@j-davis.com> writes:
> On Tue, 2025-06-10 at 18:24 +0000, Jeff Davis wrote:
>> inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
> These 4 small patches were somewhat of a "false start" on 19 -- sorry
> about that. Not sure if it's worth it to revert them and reapply in a
> couple weeks, as they look pretty harmless.
Ask the RMT, I guess. I don't have any objection, but they
have final say at this stage.
regards, tom lane
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
2025-06-10 18:24 pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <jdavis@postgresql.org>
2025-06-10 19:49 ` Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <pgsql@j-davis.com>
2025-06-10 20:31 ` Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Tom Lane <tgl@sss.pgh.pa.us>
@ 2025-06-10 20:56 ` Heikki Linnakangas <hlinnaka@iki.fi>
0 siblings, 0 replies; 4+ messages in thread
From: Heikki Linnakangas @ 2025-06-10 20:56 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>; Jeff Davis <pgsql@j-davis.com>; +Cc: Jeff Davis <jdavis@postgresql.org>
On 10 June 2025 13:31:50 GMT-07:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Jeff Davis <pgsql@j-davis.com> writes:
>> On Tue, 2025-06-10 at 18:24 +0000, Jeff Davis wrote:
>>> inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
>
>> These 4 small patches were somewhat of a "false start" on 19 -- sorry
>> about that. Not sure if it's worth it to revert them and reapply in a
>> couple weeks, as they look pretty harmless.
>
>Ask the RMT, I guess. I don't have any objection, but they
>have final say at this stage.
Seems fine by me to include it in v18.
- Heikki
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-06-10 20:56 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-06-10 18:24 pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Jeff Davis <jdavis@postgresql.org>
2025-06-10 19:49 ` Jeff Davis <pgsql@j-davis.com>
2025-06-10 20:31 ` Tom Lane <tgl@sss.pgh.pa.us>
2025-06-10 20:56 ` Heikki Linnakangas <hlinnaka@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox