From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: Further clarify how recovery target parameters are applied
Date: Thu, 7 Nov 2019 16:23:25 +0100
Message-ID: <7c633354-0b2e-a303-8867-375592d885b2@2ndquadrant.com> (raw)
In-Reply-To: <CAHGQGwHN_42hsKGwZo8YjXvOR7XuqzoXxMzBacBFUDN-NQ6poA@mail.gmail.com>
References: <CAHGQGwF7tLDk=M5tGZx=ROy_o2-n9fQ5v6-fnzBNF1yWxoEZoA@mail.gmail.com>
<20191105132123.GA1578@alvherre.pgsql>
<CAHGQGwG2KenPa8hTtQ1opgpgVtMQcQ2oAx_mTkyV0YjgaN5M1w@mail.gmail.com>
<e87b6c74-ae0b-bc97-b4fd-3b26f5b25ea4@2ndquadrant.com>
<CAHGQGwHN_42hsKGwZo8YjXvOR7XuqzoXxMzBacBFUDN-NQ6poA@mail.gmail.com>
On 2019-11-06 10:49, Fujii Masao wrote:
> On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> On 2019-11-06 05:48, Fujii Masao wrote:
>>> Patch attached. As I argued upthread, IMO it's better to remove
>>> the latter description from the doc and the patch does that.
>>> Also the patch adds "mainly" into the former description.
>>
>> I think we should list explicitly what is applied and what is not. This
>> is the reference documentation after all.
>
> That's possible, but may make the document more complicated and confusing,
> I'm afraid. Because the parameters used for archive recovery and standby mode
> are not categorized cleanly.
After reading this again and again, I think the best fix to get PG12
into "correct" shape is to just remove the offending sentence:
inline patch 1: doc/src/sgml/config.sgml (+0/-0 lines) download inline-1.patchdiff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgmlindex 46bc31de4c..fdebe9bf4b 100644--- a/doc/src/sgml/config.sgml+++ b/doc/src/sgml/config.sgml@@ -3217,9 +3217,7 @@ <title>Archive Recovery</title>
takes precedence. Targeted recovery mode ends when the archived
WAL is
fully replayed, or when <varname>recovery_target</varname> is
reached.
In this mode, the parameters from both this section and <xref
- linkend="runtime-config-wal-recovery-target"/> will be used.
Parameters
- from <xref linkend="runtime-config-replication-standby"/> will not be
- used.
+ linkend="runtime-config-wal-recovery-target"/> will be used.
</para>
<variablelist>
As we are discussing in other threads, there is further opportunity to
reorganize how these settings interact, but that's a different project.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, masao.fujii@gmail.com, alvherre@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: Further clarify how recovery target parameters are applied
In-Reply-To: <7c633354-0b2e-a303-8867-375592d885b2@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox