From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: With gssencmode='require', check credential cache before connect
Date: Tue, 9 Apr 2024 08:14:53 +0300
Message-ID: <7c8d2655-9d2d-42e9-94c1-cee76e08468b@iki.fi> (raw)
In-Reply-To: <20240409.104613.1653854506705708036.horikyota.ntt@gmail.com>
References: <E1rtcH1-0012Sj-Hn@gemulon.postgresql.org>
<20240409.104613.1653854506705708036.horikyota.ntt@gmail.com>
On 09/04/2024 04:46, Kyotaro Horiguchi wrote:
> Hello.
>
> At Sun, 07 Apr 2024 23:50:08 +0000, Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote in
>> With gssencmode='require', check credential cache before connecting
>
> This commit adds the following error message (indentations are adjusted):
>
> + libpq_append_conn_error(conn,
> + "GSSAPI encryption required but it is not supported over a local socket)");
>
> The closing parenthesis at the end of the message seems to be a
> leftover from editing.
Fixed, thanks!
> About the following message:
>
> + libpq_append_conn_error(conn, "could not set ssl alpn extension: %s", err);
>
> I'm not sure about the policy for writing acronyms in lowercase, but
> other occurrences of ALPN (in backend code) seem to be written in
> uppercase.
Changed to uppercase. I also changed "ssl" to uppercase, for consistency
with the "could not set SSL Server Name Indication (SNI)" message earlier.
To be even more consistent, we should perhaps spell out "SSL
Application-Layer Protocol Negotiation (ALPN)", but that's pretty long
and I don't think it really helps the user. It really should not fail,
and there isn't anything the user can really do if that fails. Anyone
who doesn't already know what ALPN is will need to google it anyway.
--
Heikki Linnakangas
Neon (https://neon.tech)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: hlinnaka@iki.fi, horikyota.ntt@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: With gssencmode='require', check credential cache before connect
In-Reply-To: <7c8d2655-9d2d-42e9-94c1-cee76e08468b@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox