pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Kevin Grittner <kgrittn@ymail.com>
To: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
To: pgsql-committers@postgresql.org <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Date: Fri, 17 Jul 2015 14:16:21 +0000 (UTC)
Message-ID: <81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com> (raw)
In-Reply-To: <E1ZEvoc-0002RV-Vh@gemulon.postgresql.org>
References: <E1ZEvoc-0002RV-Vh@gemulon.postgresql.org>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote:

> This fixes bug #13126, reported by Kirill Simonov.

It looks like you missed something with the addition of
AT_ReAddComment:

test_ddl_deparse.c:80:11: warning: enumeration value 'AT_ReAddComment' not handled in switch [-Wswitch]
                switch (subcmd->subtype)
                        ^

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (13+ messages)  latest in thread

Message-ID: <81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com>
Permalink:  ../81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com/
Also on:    postgresql.org/message-id/81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: kgrittn@ymail.com, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
  In-Reply-To: <81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox