public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Jacob Champion <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: libpq: Grease the protocol by default
Date: Tue, 24 Feb 2026 20:30:29 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOYmi+=uOei_D4rvPT_r5Ph7r3bR_Vq8ZpN62RE-u5TiBLyx6Q@mail.gmail.com>
References: <[email protected]>
<CAOYmi+=4QhCjssfNEoZVK8LPtWxnfkwT5p-PAeoxtG9gpNjqOQ@mail.gmail.com>
<[email protected]>
<CAOYmi+k8ENYkErqSEYEqW39YWPfe_ii7g5Acm1c9asNuRMriNg@mail.gmail.com>
<[email protected]>
<CAOYmi+mtFBsB2zePSvbpa-2Zb-+V5bov_t2BzkGH7vfKX0ny_w@mail.gmail.com>
<[email protected]>
<CAOYmi+kC3AN0QJKT0OunHCmi4UU7-15eu7w-DY5ckOgHiQE1QA@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CAOYmi+=uOei_D4rvPT_r5Ph7r3bR_Vq8ZpN62RE-u5TiBLyx6Q@mail.gmail.com>
Jacob Champion <[email protected]> writes:
> Oh, the envvar is clever. You'll probably want to do that only for the
> pg_dumpall invocation now that pg_upgrade is patched, though, so we
> don't cover up regressions.
I can confirm clean x-version tests on all branches with git tip
and this:
--- TestUpgradeXversion.pm.orig 2025-11-25 07:47:25.000000000 -0500
+++ TestUpgradeXversion.pm 2026-02-24 18:50:29.487530840 -0500
@@ -485,10 +485,14 @@ sub test_upgrade ## no critic (Subrou
# use the NEW pg_dumpall so we're comparing apples with apples.
setinstenv($self, "$installdir", $save_env);
+ local $ENV{PGMAXPROTOCOLVERSION} =
+ ($oversion le 'REL9_2_STABLE') ? "3.0" : "latest";
+
system( qq{"$installdir/bin/pg_dumpall" $dump_opts -p $sport -f }
. qq{"$upgrade_loc/origin-$oversion.sql" }
. qq{> "$upgrade_loc/$oversion-dump1.log" 2>&1});
return if $?;
+ delete $ENV{PGMAXPROTOCOLVERSION};
setinstenv($self, "$other_branch/inst", $save_env);
system( qq{"$other_branch/inst/bin/pg_ctl" -D }
which is Andrew's patch but with the envvar dropped as soon
as possible.
regards, tom lane
view thread (27+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgsql: libpq: Grease the protocol by default
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox